Ditch default -static for Windows builds.
#311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
commented
Jul 30, 2023
dhermes
commented
Jul 30, 2023
| @@ -23,8 +23,6 @@ if(NOT CMAKE_BUILD_TYPE) | |||
| endif() | |||
|
|
|||
| if(WIN32 AND CMAKE_Fortran_COMPILER_ID STREQUAL "GNU") | |||
| set(CMAKE_SHARED_LINKER_FLAGS "${CMAKE_SHARED_LINKER_FLAGS} -static") | |||
dhermes
commented
Jul 30, 2023
|
|
||
| os.add_dll_directory(extra_dll_dir) | ||
| os.add_dll_directory(extra_dll_dir) |
There was a problem hiding this comment.
Oh shoot I meant to test this!
dhermes
commented
Jul 31, 2023
| libgcc_s_seh-1-5c71c85c0ca01174917203266ba98140.dll | ||
| libgfortran-5-08073c6868a1df2cbc5609e49cbe3ad8.dll | ||
| KERNEL32.dll | ||
| msvcrt.dll |
There was a problem hiding this comment.
I have 13.1.0 on my dev machine (via MSYS2 + pacman) but GitHub Actions has 11.2.0.07112021 (via Chocolatey).
In addition to hash differences, this also produces ordering differences. In 13.1.0, the order is:
libgcc_s_seh-1-5c71c85c0ca01174917203266ba98140.dll
KERNEL32.dll
msvcrt.dll
libgfortran-5-08073c6868a1df2cbc5609e49cbe3ad8.dll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an awesome milestone for the Windows ecosystem here for scientific Python (or the wider "Python + extensions" ecosystem).
It's so great that https://github.com/adang1345/delvewheel exists! H/T to @adang1345!