review comments

dhermes · Nov 8, 2016 · bf4044f · bf4044f
1 parent ca014d7
commit bf4044f
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 13 deletions.
diff --git a/firestore/MANIFEST.in b/firestore/MANIFEST.in
@@ -1,5 +1,4 @@
 include README.rst
 graft google
 graft unit_tests
-global-include *.json
 global-exclude *.pyc
diff --git a/firestore/google/__init__.py b/firestore/google/__init__.py
@@ -1,4 +1,3 @@
-
 # Copyright 2016 Google Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/firestore/google/cloud/__init__.py b/firestore/google/cloud/__init__.py
@@ -1,4 +1,3 @@
-
 # Copyright 2016 Google Inc.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

diff --git a/firestore/google/cloud/firestore/__init__.py b/firestore/google/cloud/firestore/__init__.py
@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
 """Firestore database API public classes."""
 
 from google.cloud.firestore.client import Client
diff --git a/firestore/google/cloud/firestore/client.py b/firestore/google/cloud/firestore/client.py
@@ -12,11 +12,11 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-"""Firestore database API."""
+"""Firestore database SDK Client."""
 
 
 class Client(object):
-    """Top level Firestore database instance.
+    """Firestore Client.
 
     :type project: str
     :param project: (optional) Project containing the Firestore database.

diff --git a/firestore/setup.py b/firestore/setup.py
@@ -50,11 +50,7 @@
 }
 
 REQUIREMENTS = [
-    'grpcio>=1.0.0, <2.0.0dev',
-    'googleapis-common-protos>=1.3.4, <2.0.0dev',
-    'google-gax>=0.14.1, <0.15.0dev',
-    'oauth2client>=3.0.0, <4.0.0dev',
-    'google-cloud-core>=0.20',
+    'google-cloud-core >= 0.20',
 ]
 
 setup(

diff --git a/firestore/unit_tests/test_client.py b/firestore/unit_tests/test_client.py
@@ -11,16 +11,13 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-"""Unit tests for Google Firestore SDK."""
 
 import unittest
 
 from google.cloud.firestore import Client
 
 
 class TestFirestore(unittest.TestCase):
-    """Unit Tests for the google.cloud.firestore.Client."""
-
     def test_constructor(self):
         with self.assertRaises(NotImplementedError):
             Client('my-project-id')