Brain dump of changes to lib/statsd.js.
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
September 28, 2020 09:40
…` in constructor. Also using these in places where `options` was used.
This way we can retry using this helper.
This is in advance of a change that will allow these to be OS specific.
See https://nodejs.org/docs/latest-v12.x/api/errors.html for an example (in `error.errno`) explaining why error codes are negative.
This way `this.socket` is only replaced if `createTransport()` returned an actual socket (vs. `null`).
See: https://travis-ci.org/github/brightcove/hot-shots/jobs/730354851 This was due to `eslint` failures. Also changed some `==` to `===` and added / removed some `;` in lines that needed / didn't need.
This "bug" was introduced to my bugfix in a re-factor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.