Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4.0.0 #31

Merged
merged 32 commits into from
Nov 24, 2020
Merged

v4.0.0 #31

merged 32 commits into from
Nov 24, 2020

Conversation

dhershman1
Copy link
Owner

@dhershman1 dhershman1 commented Nov 23, 2020

Should address #30

BREAKING CHANGES

  • Converted from tap-out to tap-parser
    • This change means that the xml generated is now "Flat" (see below)
    • This removes the error count as there isn't an event for this anymore
    • Skips are handled WAY better and more naturally with TAP
    • This should flow better with proper tap output
  • If a file extension is set in the command, it will be used for the generated file, if not .xml will be used
  • Error counter removed with new parser
  • The testcase name no longer has test number, the test number is now provided in the id attribute of testcase

New

  • Todo support

Improved

  • Optimized performance from both parsing and serializing
  • Data is built more dynamically, instead of relying on certain keys to exist
  • Better JUnit formatting
  • Moved from xmlbuilder to xmlbuilder2 (In Progress)

Flat XML

Now <testsuits> containes only a singular <testsuite> element, within that all of the <testcase> elements now live. Here's an example:

v3 tap-junit output:

<testsuites tests="4" name="suite-name" failures="0" errors="0">
  <testsuite tests="3" failures="0" errors="0" name="1 === 1">
    <testcase name="#1 test is equal"/>
    <testcase name="#2 test skip extra # SKIP">
      <skipped/>
    </testcase>
    <testcase name="#3 should not be equal"/>
  </testsuite>
  <testsuite tests="1" failures="0" errors="0" name="2 === 2">
    <testcase name="#4 should be equal"/>
  </testsuite>
  <testsuite tests="0" failures="0" errors="0" name="SKIP skipped test"/>
</testsuites>

v4 tap-junit output:

<testsuites tests="4" name="Tap-Junit" failures="2">
  <testsuite tests="4" failures="2" skipped="1">
    <testcase id="1" name="test is equal"/>
    <testcase id="2" name="test skip extra # SKIP">
      <skipped/>
    </testcase>
    <testcase name="#3 should not be equal"/>
    <testcase id="3" name="should not be equal"/>
    <testcase id="4" name="should be equal"/>
  </testsuite>
</testsuites>

@dhershman1
Copy link
Owner Author

Still working out the kinks on some BAT file Comment based messages, as mentioned in #23

@dhershman1
Copy link
Owner Author

Also re writing how the serialization works in v4.0.0 with xmlbuilder2

@dhershman1 dhershman1 added this to the 4.0.0 milestone Nov 24, 2020
@dhershman1 dhershman1 merged commit e62f699 into master Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant