chore: fix cli-style useEffect exhaustive deps warnings (#753)

dhis2 · Oct 4, 2022 · 47fc9ff · 47fc9ff
1 parent a91dc6e
commit 47fc9ff
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/adapter/src/components/Alerts.js b/adapter/src/components/Alerts.js
@@ -25,9 +25,12 @@ const Alerts = () => {
         )
 
     useEffect(() => {
-        if (alertManagerAlerts.length > 0 || alertStackAlerts.length > 0) {
-            setAlertStackAlerts(
-                mergeAlertStackAlerts(alertStackAlerts, alertManagerAlerts)
+        if (alertManagerAlerts.length > 0) {
+            setAlertStackAlerts((currentAlertStackAlerts) =>
+                mergeAlertStackAlerts(
+                    currentAlertStackAlerts,
+                    alertManagerAlerts
+                )
             )
         }
     }, [alertManagerAlerts])

diff --git a/examples/pwa-app/src/components/VisualizationsList.js b/examples/pwa-app/src/components/VisualizationsList.js
@@ -44,7 +44,7 @@ export default function VisualizationsList() {
             }
         }
         cascadingFetch()
-    }, [])
+    }, [engine])
 
     return (
         <>