feat: build unbundled libraries, validate package when building (LIBS-125) #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
amcgee
changed the title
amcgee
changed the title
amcgee
changed the title
mediremi
reviewed
Feb 19, 2021
mediremi
reviewed
Feb 19, 2021
amcgee
changed the title
|
I don't think we need a breaking change here but @varl might disagree - will hold off on merging for a short bit to get more eyes on this. We could also merge to |
|
I'm going to add some documentation then go ahead and merge this, as we want to get it rolling through the ecosystem. If we find the "pseudo-break" too cumbersome we can back it out and cut a breaking change instead. |
dhis2-bot
added a commit
that referenced
this pull request
Feb 20, 2021
# [5.6.0](v5.5.3...v5.6.0) (2021-02-20) ### Features * build unbundled libraries, validate package when building (LIBS-125) ([#492](#492)) ([4fb3fae](4fb3fae))
|
🎉 This PR is included in version 5.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This was referenced Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the diverging logic between application and library builds. It no longer uses rollup, shares a single babel config, and compiles library files individually rather than bundling them into a single
lib.jsfile (which is better for tree shaking)This also adds the concept of package validation to
d2-app-scripts. This allows the build tool to show hints, offer automatic fixes, and bail on CI if the app or library being built is misconfigured. Additional validations for singleton dependencies, yarn versions, and more could be added in the future (as has been done in #491 here)The first validator added here ensures that
package.main,package.moduleandpackage.exportsare set correctly for library builds - since thelib.jsfile is no longer generated, this will prevent an upgrade of@dhis2/cli-app-scriptsfrom silently breaking library builds (which should mean we don't need to cut a breaking change here, though we could if we want to)Example output with prompt to automatically fix the package export fields (declined here):
And another when
./build/<type>/lib.jsis incorrectly specified (prompt accepted here):