Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): wrap App component in CustomDataProvider in boilerplate test #678

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

mediremi
Copy link
Contributor

@mediremi mediremi commented Oct 8, 2021

In #677 I attempted to fix an incorrect test created when initialising an app. Unfortunately, the file I changed was the wrong one. This PR corrects cli/config/init.App.test.js, which is the correct file.

@mediremi mediremi requested a review from a team October 8, 2021 15:37
@mediremi mediremi merged commit 88be6eb into master Oct 13, 2021
@mediremi mediremi deleted the fix/cli-init-app-test branch October 13, 2021 09:11
dhis2-bot added a commit that referenced this pull request Oct 14, 2021
## [8.2.3](v8.2.2...v8.2.3) (2021-10-14)

### Bug Fixes

* **cli:** run yarn install after fixing yarn.lock by deduplicating ([#676](#676)) ([a32f969](a32f969))
* **cli:** wrap App component in CustomDataProvider in boilerplate test ([#678](#678)) ([88be6eb](88be6eb))
* **pwa:** update gracefully despite missing clients info ([#679](#679)) ([c7fe509](c7fe509))
@dhis2-bot
Copy link
Contributor

🎉 This PR is included in version 8.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants