feat: implement plugin wrapper (receiver in plugin) #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomzemp
commented
Feb 20, 2023
|
|
||
| const Plugin = ({ config }) => { | ||
| return ( | ||
| <PluginOuterErrorBoundary> |
There was a problem hiding this comment.
this exists, so that an error in PluginLoader could be caught. I'm not really sure that this is ultimately necessary* as most of the logic there is just to handle the post-robot communication which is set to silently fail, so as not to impede plugin's usability if communication is not needed. If we do want an error boundary here, I guess we could reuse the same one from app-platform/adapter?
- right now, it's necessary based on how required props are being handled, but I think this should probably change
2 tasks
dhis2-bot
added a commit
that referenced
this pull request
Mar 13, 2023
# [10.4.0-alpha.1](v10.3.1...v10.4.0-alpha.1) (2023-03-13) ### Bug Fixes * merge in master branch of app-platform ([5c637c0](5c637c0)) * pass props with spread operator ([bd4dccb](bd4dccb)) * simplify error reset logic ([d40dfba](d40dfba)) * style adapter package file ([d5e17e1](d5e17e1)) ### Features * implement plugin wrapper (receiver in plugin) (alpha) ([#786](#786)) ([d4f1ee2](d4f1ee2)) * plugin error handling ([7fd0605](7fd0605)) * plugin handling ([7ee8ed6](7ee8ed6))
|
🎉 This PR is included in version 10.4.0-alpha.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is conceived in conjunction with PR in app-runtime to provide plugin wrappers.
The main change in this code is adding PluginLoader in the app shell which sets up communication with the parent window. For the communication to work, PluginSender needs to be used in the app, otherwise, the communication will fail (the plugin would still load, so you can still build a plugin with this updated app shell and not use PluginSender if you do not want this communication channel, but do want a separate plugin build)
There is some additional updates in app/adapter for hoisting plugin alerts and errors.
Some notes