fix: omit moment-locales from precache
#806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Birkbjo
reviewed
Apr 27, 2023
| const restOfManifest = precacheManifest.filter((e) => { | ||
| return ( | ||
| e !== indexHtmlManifestEntry && | ||
| !e.url.startsWith('./static/js/moment-locales/') |
There was a problem hiding this comment.
Would be nice to change this to a pattern-array to make it less hardcoded. Eg.
MANIFEST_EXCLUDE_URL_PATTERNS = [^\.\/static\/js\/moment-locales\/]
// not sure if ^ (start of string) is necessary now it's a pattern though
return (e !== indexHtmlManifestEntry &&
MANIFEST_EXCLUDE_URL_PATTERNS.some(p => p.test(e.url))
)
Birkbjo
reviewed
Apr 27, 2023
| const entryShouldBeExcluded = CRA_MANIFEST_EXCLUDE_PATTERNS.some( | ||
| (pattern) => pattern.test(e.url) | ||
| ) | ||
| if (entryShouldBeExcluded) { |
Birkbjo
approved these changes
Apr 27, 2023
dhis2-bot
added a commit
that referenced
this pull request
Apr 27, 2023
## [10.3.7](v10.3.6...v10.3.7) (2023-04-27) ### Bug Fixes * omit `moment-locales` from precache ([#806](#806)) ([c8d5494](c8d5494))
|
🎉 This PR is included in version 10.3.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
dhis2-bot
added a commit
that referenced
this pull request
Aug 10, 2023
# [10.4.0-alpha.3](v10.4.0-alpha.2...v10.4.0-alpha.3) (2023-08-10) ### Bug Fixes * move precache route to reenable navigation handler on login redirects [LIBS-473] ([#809](#809)) ([1ff29b6](1ff29b6)) * **pwa:** avoid crashing when SW is not available [LIBS-499] ([#807](#807)) ([b681022](b681022)) * omit `moment-locales` from precache ([#806](#806)) ([c8d5494](c8d5494)) * **cli:** fix envs to fix plugins in dev ([#799](#799)) ([ba29cea](ba29cea)) * **plugins:** omit launch paths when unused [LIBS-477] ([#791](#791)) ([e49a51f](e49a51f)) * **pwa:** bump ui version for headerbar connection status [LIBS-315] ([#797](#797)) ([61ff0a4](61ff0a4)) * make loading placeholders transparent ([#795](#795)) ([6e64756](6e64756)) * **plugins:** inject precache manifest correctly ([#792](#792)) ([c0d172e](c0d172e)) * **pwa:** add config option to omit files from precache [LIBS-482] ([#793](#793)) ([d089dda](d089dda))
|
🎉 This PR is included in version 10.4.0-alpha.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to help with https://dhis2.atlassian.net/browse/DHIS2-15097
Part of https://dhis2.atlassian.net/browse/LIBS-498
This saves approximately 140 files from the precache, which should speed up SW installation time significantly.
I noticed the moment locales are seldom fetched, and can be cached by the Network First strategy instead to save precaching time.