Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up for plugins [LIBS-620] #851

Merged
merged 3 commits into from
Jun 6, 2024
Merged

fix: clean up for plugins [LIBS-620] #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4b73d7
fix: clean up plugin css
tomzemp Jun 4, 2024
6af1064
fix: prop types cleanup
tomzemp Jun 4, 2024
997254f
fix: remove translucent layer from plugin loader
tomzemp Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adapter/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ AppAdapter.propTypes = {
parentAlertsAdd: PropTypes.func,
plugin: PropTypes.bool,
pwaEnabled: PropTypes.bool,
showAlertsInPlugin: PropTypes.func,
showAlertsInPlugin: PropTypes.bool,
url: PropTypes.string,
onPluginError: PropTypes.func,
}
Expand Down
6 changes: 3 additions & 3 deletions shell/src/PluginLoader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ const PluginInner = ({
// inner div disables margin collapsing which would prevent computing correct height
return (
<div ref={divRef}>
<div style={{ display: 'flex', width: 'fitContent' }}>
<div>
<div id="innerDiv" ref={innerDivRef}>
<D2App
config={config}
Expand All @@ -66,7 +66,7 @@ const PluginInner = ({
PluginInner.propTypes = {
D2App: PropTypes.object,
config: PropTypes.object,
propsFromParent: PropTypes.array,
propsFromParent: PropTypes.object,
resizePluginHeight: PropTypes.func,
resizePluginWidth: PropTypes.func,
}
Expand Down Expand Up @@ -196,7 +196,7 @@ export const PluginLoader = ({ config, requiredProps, D2App }) => {
>
<React.Suspense
fallback={
<Layer translucent level={layers.alert}>
<Layer level={layers.alert}>
<CenteredContent>
<CircularLoader />
</CenteredContent>
Expand Down
Loading