fix(deps): upgrade @dhis2/cli-app-scripts for peer deps fixes [LIBS-578] #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaiVandivier
force-pushed
the
libs-587-upgrade-cli-app-scripts
branch
from
dee0315
to
fa88633
Compare
KaiVandivier
force-pushed
the
libs-587-upgrade-cli-app-scripts
branch
from
fa88633
to
c3727c3
Compare
kabaros
approved these changes
Jul 4, 2024
dhis2-bot
added a commit
that referenced
this pull request
Jul 4, 2024
## [4.2.5](v4.2.4...v4.2.5) (2024-07-04) ### Bug Fixes * **deps:** upgrade @dhis2/cli-app-scripts for peer deps fixes [LIBS-578] ([#624](#624)) ([02ce484](02ce484))
|
🎉 This PR is included in version 4.2.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LIBS-578
Fixes peer dependency conflicts that were causing infinite loops when using
npmv7+ to install the d2 cli. Can be tested using the latestalphaversion of@dhis2/cli:Note: this constitutes a breaking change, since the minimum Node version will now be 16Update: this change did not introduce the Node 14 incompatibility; it was actually present previously with
cli-app-scripts. For that reason... I think a major version bump isn't necessary, but it's a bit awkward that a breaking change has happened outside of our control.A quick summary: When running
d2 app scripts initon Node 14, this error breaks the installation:What's happening: A broken version of
workbox-webpack-plugin("wwp" for short, from here on) was released as a feature (v6.6.0/v6.6.1) that breaks Node 14 compatibility.@dhis2/cli-app-scriptsdepends onreact-scriptswhich depends onwwp@^6.4.1, so when@dhis2/cli-app-scriptsgets installed, thewwpversion resolves to the broken 6.6.1 and causes a failed installation on Node 14.This affects
@dhis2/cli-app-scriptsdown to v7.6.0, due its ownworkboxdependency, but nowreact-scriptsalso has that dependency since@dhis2/cli-app-scripts v10, and that dependency of a dependency is now a bit out ofcli-app-scripts's control to fix as far as I can tell.A workaround for consuming apps of
@dhis2/cli-app-scriptsis to add aresolutionfield on"workbox-webpack-plugin": "6.5.4"exactly.To patch
d2 app scripts init, the createdpackage.jsonin the bootstrapped app could come with thatresolutionfield already.However,
...since we're moving to Vite soon, Vite will already increase the minimum supported Node version to 18+, so maybe this issue with
workboxisn't worth fussing over.