-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: serve global app shell at /apps/ [DHIS2-17021] #16703
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16703 +/- ##
============================================
- Coverage 67.16% 67.14% -0.03%
- Complexity 32181 32183 +2
============================================
Files 3556 3557 +1
Lines 131870 131931 +61
Branches 15316 15325 +9
============================================
+ Hits 88574 88582 +8
- Misses 36099 36153 +54
+ Partials 7197 7196 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalAppShellFilter.java
Fixed
Show fixed
Hide fixed
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalAppShellFilter.java
Fixed
Show fixed
Hide fixed
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalAppShellFilter.java
Fixed
Show fixed
Hide fixed
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalAppShellFilter.java
Fixed
Show fixed
Hide fixed
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalAppShellFilter.java
Fixed
Show fixed
Hide fixed
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalAppShellFilter.java
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalAppShellFilter.java
Outdated
Show resolved
Hide resolved
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/filter/GlobalShellFilter.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Path replacement was discussed in today's meeting - it would be good to have a high level explanation somewhere, maybe in form of javadoc.
dhis-2/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/AppController.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
If an app with the name
global-app-shell
is installed this filter will take effect./apps/
(including top-level subpaths such as/apps/dashboard
)/dhis-web-dashboard/index.html
) to the global app shell path for the same app (/apps/dashboard
)/apps/dashboard/
to/apps/dashboard
__DHIS_BASE_URL__
(ideally included in index.html as<meta name="dhis-base-url" content="__DHIS2_BASE_URL__" />
). This is particularly helpful for the global app shell itself, but can also be leveraged by any other app?redirect=false
A few things still to iron out...
__DHIS2_BASE_URL__
runtime replacement (this might be OK for now...)/apps/dashboard
back to/dhis-web-dashboard
if the app shell has been uninstalledwebapp.manifest
orplugin.html
) manually to the global app shell public URL will no longer work. For example/apps/dashbaord/webapp.manifest
or/apps/dashboard/package.json
will return a 404. This could be confusing and obnoxious, but mostly for developers and expert users... perhaps these paths should redirect back to their source counterparts...?