-
-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable button on Menu not working on certain urls #2454
Comments
I understood the issue now. It seems that now "disable on current page" option should be possible when you are at the home of the domain, for example:
It should only be possible when we are at some specific page :
THis was causing a bug where one couldn't disable that domain anymore because of an errouneus entry to the 'trusted sites' tab. I will disable the "on this page" option when the user is at the home of the domain. |
This may be difficult/impossible to detect in some cases, so please verify sensible default behavior/messaging when we are on a specific/unique page with a URL containing only a domain (which would incorrectly register as a 'home' page) |
How ublock implements it, is that if you are on 'home' page of a domain, you don't have the option to disable only on page, and only allows for 'domain' disable instead. I thought this behaviour would be sensible? |
This is now fixed, closing. |
Based on what was shared in this discussion thread, there is a bug on the 'disabled' button which I have now just confirmed. It not happening on all pages, investigating why.
where bug is present:
where is not
The text was updated successfully, but these errors were encountered: