Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable button on Menu not working on certain urls #2454

Closed
mneunomne opened this issue Nov 8, 2023 · 4 comments
Closed

Disable button on Menu not working on certain urls #2454

mneunomne opened this issue Nov 8, 2023 · 4 comments
Assignees

Comments

@mneunomne
Copy link
Collaborator

Based on what was shared in this discussion thread, there is a bug on the 'disabled' button which I have now just confirmed. It not happening on all pages, investigating why.

where bug is present:

nytimes.com 

where is not

g1.globo.com
@mneunomne
Copy link
Collaborator Author

I understood the issue now.

It seems that now "disable on current page" option should be possible when you are at the home of the domain, for example:

https://nytimes.com/

It should only be possible when we are at some specific page :

https://www.nytimes.com/2023/11/08/world/middleeast/hamas-israel-gaza-war.html

THis was causing a bug where one couldn't disable that domain anymore because of an errouneus entry to the 'trusted sites' tab.

I will disable the "on this page" option when the user is at the home of the domain.

This was referenced Nov 8, 2023
@dhowe
Copy link
Owner

dhowe commented Nov 10, 2023

This may be difficult/impossible to detect in some cases, so please verify sensible default behavior/messaging when we are on a specific/unique page with a URL containing only a domain (which would incorrectly register as a 'home' page)

@mneunomne
Copy link
Collaborator Author

How ublock implements it, is that if you are on 'home' page of a domain, you don't have the option to disable only on page, and only allows for 'domain' disable instead. I thought this behaviour would be sensible?

@mneunomne
Copy link
Collaborator Author

This is now fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants