Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

id: add ambient detector for CircleCI #144

Merged
merged 4 commits into from
Dec 12, 2023
Merged

id: add ambient detector for CircleCI #144

merged 4 commits into from
Dec 12, 2023

Conversation

woodruffw
Copy link
Collaborator

@woodruffw woodruffw commented Dec 11, 2023

This adds ambient detection on CircleCI, based on these docs: https://circleci.com/docs/oidc-tokens-with-custom-claims/

I haven't tested it directly yet -- if we get this repo hooked up to CircleCI, then I can probably add a workflow similar to the GCB one 🙂

Replace `isort` and `black` with `ruff`.

Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
@woodruffw woodruffw marked this pull request as ready for review December 11, 2023 22:01
@woodruffw woodruffw requested a review from di December 11, 2023 22:03
@woodruffw woodruffw self-assigned this Dec 11, 2023
Copy link
Owner

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I made a PR to enable a CircleCI workflow in #145

@woodruffw
Copy link
Collaborator Author

Cool! I'll merge both and do a follow-up integrating into the CircleCI workflow.

@woodruffw woodruffw merged commit b6ff8e5 into main Dec 12, 2023
13 checks passed
@woodruffw woodruffw deleted the ww/circleci branch December 12, 2023 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants