-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: capacitor 5 support #60
Conversation
Thanks. I have kept the iOS deployment target at 12.0 to support Capacitors v3 and v4. |
Then I cant use this version. I cant build the app with target 12.0 when using capacitor 4+. I really dont understand why you not gonna release a 5.0.0 version which is just compatible with capacitor 5 (as I already mentioned in another ticket). I really appreciate your work and dont want to be 'mad' here, but please understand that its inefficient for the users with the same problem as me (Build error - target must be 13) to publish this somewhere separatelly as custom version with a raised target. |
I don't get that error when building the demo, which uses Capacitor v5. What happens if you try to build it? |
The build cancels with this error. |
Why don't I get the error? I am using Xcode 14.3. |
I dont have an answer to this. This plugin is in my oppinion not compatible with capacitor 4+. https://forum.ionicframework.com/t/upgrading-custom-plugins-from-capacitor-3-to-capacitor-4/231753 |
I would like to know whether your build environment is the exception, or mine. I would rather not maintain several version of this plugin unless absolutely necessary. |
In my project.pbxproj I have set And in the Podfile |
Do you have the deployment target set? I thinkg it should be the IPHONEOS_DEPLOYMENT_TARGET as mentioned before. If I understand it correctly, it should define the min sdk version. |
Yes, those are the values I see in the demo project. |
You have tried building the demo app, right? It's here: https://github.com/diachedelic/capacitor-blob-writer/tree/master/demo. |
No, just our project. Unfortunately I have currently not the possibility to test this. |
I appended this as workaround to my podfile:
capacitor-community/file-opener#36 (comment) |
I wonder how file-opener does it? |
Closes #59