Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: capacitor 5 support #60

Closed
wants to merge 1 commit into from
Closed

feat: capacitor 5 support #60

wants to merge 1 commit into from

Conversation

AE1NS
Copy link

@AE1NS AE1NS commented May 4, 2023

Closes #59

@diachedelic
Copy link
Owner

Thanks. I have kept the iOS deployment target at 12.0 to support Capacitors v3 and v4.

@diachedelic diachedelic closed this May 5, 2023
@AE1NS
Copy link
Author

AE1NS commented May 5, 2023

Then I cant use this version. I cant build the app with target 12.0 when using capacitor 4+. I really dont understand why you not gonna release a 5.0.0 version which is just compatible with capacitor 5 (as I already mentioned in another ticket).

I really appreciate your work and dont want to be 'mad' here, but please understand that its inefficient for the users with the same problem as me (Build error - target must be 13) to publish this somewhere separatelly as custom version with a raised target.

@AE1NS
Copy link
Author

AE1NS commented May 5, 2023

grafik
Just installed the new released version. This is the error.

@diachedelic
Copy link
Owner

I don't get that error when building the demo, which uses Capacitor v5. What happens if you try to build it?

@AE1NS
Copy link
Author

AE1NS commented May 5, 2023

The build cancels with this error.

@diachedelic
Copy link
Owner

Why don't I get the error? I am using Xcode 14.3.

@AE1NS
Copy link
Author

AE1NS commented May 5, 2023

I dont have an answer to this.

This plugin is in my oppinion not compatible with capacitor 4+.

https://forum.ionicframework.com/t/upgrading-custom-plugins-from-capacitor-3-to-capacitor-4/231753

@diachedelic
Copy link
Owner

I would like to know whether your build environment is the exception, or mine. I would rather not maintain several version of this plugin unless absolutely necessary.

@AE1NS
Copy link
Author

AE1NS commented May 5, 2023

In my project.pbxproj I have set IPHONEOS_DEPLOYMENT_TARGET = 13.0; in the buildSettings area.

And in the Podfile platform :ios, '13.0'

@AE1NS
Copy link
Author

AE1NS commented May 5, 2023

Do you have the deployment target set? I thinkg it should be the IPHONEOS_DEPLOYMENT_TARGET as mentioned before. If I understand it correctly, it should define the min sdk version.
https://stackoverflow.com/questions/49624300/does-ios-app-development-have-minimum-target-sdk-version-similar-to-androids

@diachedelic
Copy link
Owner

Yes, those are the values I see in the demo project.

@diachedelic
Copy link
Owner

You have tried building the demo app, right? It's here: https://github.com/diachedelic/capacitor-blob-writer/tree/master/demo.

@AE1NS
Copy link
Author

AE1NS commented May 5, 2023

No, just our project. Unfortunately I have currently not the possibility to test this.

@AE1NS
Copy link
Author

AE1NS commented May 8, 2023

I appended this as workaround to my podfile:

post_install do |installer|
  installer.pods_project.targets.each do |target|
    target.build_configurations.each do |config|
      if target.name == "CapacitorBlobWriter"
        config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
      end
    end
  end
end

capacitor-community/file-opener#36 (comment)
fyi: This developer seems to have a compatibility for 3, 4 and 5 with target 13.0.

@diachedelic
Copy link
Owner

I wonder how file-opener does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Capacitor 5 support
3 participants