Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition for electron diffraction data processing files from quartz #346

Merged
merged 5 commits into from
Mar 7, 2022

Conversation

dagewa
Copy link
Member

@dagewa dagewa commented Feb 17, 2022

Draft; URLs need updating after dials/data-files#40 is merged

@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #346 (490b258) into master (59becd5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files           6        6           
  Lines         365      365           
=======================================
  Hits          203      203           
  Misses        162      162           

@dagewa dagewa marked this pull request as ready for review February 28, 2022 09:52
@dagewa
Copy link
Member Author

dagewa commented Mar 7, 2022

I plan to merge this by the end of the day unless there are objections

Copy link
Member

@Anthchirp Anthchirp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prolly fine

dials_data/definitions/quartz_processed.yml Outdated Show resolved Hide resolved
dials_data/definitions/quartz_processed.yml Outdated Show resolved Hide resolved
@dagewa dagewa enabled auto-merge (rebase) March 7, 2022 16:02
@dagewa
Copy link
Member Author

dagewa commented Mar 7, 2022

Thanks, applied suggestions and have enabled auto-merge :)

@dagewa dagewa merged commit fac7b58 into master Mar 7, 2022
@dagewa dagewa deleted the Quartz-processing branch March 7, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants