Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tensorflow lower limit conflicts #826

Open
egpbos opened this issue Jul 29, 2024 · 3 comments · May be fixed by #827
Open

Tensorflow lower limit conflicts #826

egpbos opened this issue Jul 29, 2024 · 3 comments · May be fixed by #827

Comments

@egpbos
Copy link
Member

egpbos commented Jul 29, 2024

Due to the lower limit on the Tensorflow version that dianna uses, I cannot use dianna on my particular GPU setup with its particular CUDA version installed (DAS6 @ VU). This makes me sad :( Please unsad me!

It seems the change was introduced in this PR: #588. I don't see the change motivated there, but perhaps someone remembers whether there was a valid reason.

Can this be reverted? In fact, is a lower limit on Tensorflow needed at all?

@egpbos
Copy link
Member Author

egpbos commented Jul 29, 2024

I see that the lower limit of 2.11 was introduced here bb42372, which does seem functional, so can we revert to 2.11?

@egpbos
Copy link
Member Author

egpbos commented Jul 29, 2024

On closer look, it seems like the actual issue that bb42372 resolved was #434.

The lack of dependencies specified for tensorflow-probability are the root cause then. However, they do in fact specify the minimum required tensorflow version via an extra in setup.py. This means we can drop the upper limit and replace our dependency with tensorflow-probability[tf].

I'll make a PR for this to demonstrate (and check whether it actually works 😄).

@egpbos
Copy link
Member Author

egpbos commented Jul 29, 2024

Also related: #727

egpbos added a commit that referenced this issue Jul 29, 2024
@egpbos egpbos linked a pull request Jul 29, 2024 that will close this issue
egpbos added a commit that referenced this issue Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant