Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating READMEs (issues 815 and 863) #866

Merged
merged 27 commits into from
Oct 30, 2024
Merged

Updating READMEs (issues 815 and 863) #866

merged 27 commits into from
Oct 30, 2024

Conversation

elboyran
Copy link
Contributor

Solves issues #815 and #863.

@elboyran
Updating tutorial README.md
657bf45 
Fixing a wrong EU law case logo in tutorials table
@elboyran elboyran added the documentation Improvements or additions to documentation label Oct 11, 2024
@elboyran elboyran self-assigned this Oct 11, 2024
@elboyran elboyran linked an issue Oct 11, 2024 that may be closed by this pull request
Update dashboard and main README #815
Closed
9 tasks
@elboyran
Update tutorial README.md
43cab51 
Shorten the readme using summary and details.
Issues #863.
@elboyran elboyran linked an issue Oct 11, 2024 that may be closed by this pull request
Use collapsed sections in main and tutorial README #863
Closed
9 tasks
elboyran and others added 16 commits October 11, 2024 11:17
@elboyran
Update README.md
42c35d2 
Shorten using collapsed sections. 
Issue #863
@elboyran
Update _shared.py
70a7653 
added dianna goddess logo
@elboyran
Update Home.py
acd7cf3 
added goddess in  sidebar
@elboyran
adding Diana goddess logo
5c07df7
@elboyran
Update README.md
00a1f82 
Dashboard section update.
@elboyran
Update README.md
c328ae7 
Added dashboard screenshot.
@elboyran
Update dashboard readme.md
dcc9581 
Added dashboard screenshot
@elboyran
Update Home.py
c85470a 
Less links, use the RSD one as a main one.
@elboyran
Update README.md
ced665b 
moved the place for the intro video
@elboyran
Update README.md
383ea7c 
Screenshot of the latest initial page of the dashboard
@elboyran
Update README.md
3fd447f 
Added the EU law dataset to Datasets table
@elboyran
Update README.md
587c005 
Updating the EU law dataset DOI to the generic one.
@elboyran
Update tutorials README.md
8504422 
Updating the EU law dataset DOI to the generic one.
@elboyran
Update dashboard readme.md
cdb0b55 
Simplify and refer to the intro video using dashboard for usage.
@elboyran
Update readme.md
8214de7 
Added YouTube link to the intro video. Note that it will be released to public on 1 November!
@elboyran
Update README.md
4399bf5 
Added YouTube link to intro video using the dashboard. It will be made public on 1 November 2024.
@elboyran elboyran marked this pull request as ready for review October 17, 2024 11:47
@elboyran
Copy link
Contributor Author

Oh, as a Draft it passed all checks.... Looking at the fails now....

@elboyran
Update readme.md
8a3ac23 
fixing tutorials link
@loostrum
Copy link
Member

Oh, as a Draft it passed all checks.... Looking at the fails now....

That may be because the downloader test doesn't run on draft PRs. We disabled that to avoid many downloads while we don't change the downloader itself that much.

@elboyran elboyran removed the request for review from cwmeijer October 23, 2024 09:16
@elboyran
Update dashboard readme.md
397d105 
Introduced streamlit logo to indicate which tutorials are in the dashboard.
@elboyran
Update dashboard readme.md
e062ca0 
shorten first pagaraph
@elboyran
Update tutorials README.md
25bc0ce 
Marked with the streamlit logo the cases shown in the dashboard.
@elboyran
Copy link
Contributor Author

@loostrum Today I saw you didn't review my PR yet, so I quickly grabbed the chance ;-)
to edit a bit more the READMEs and while all checks were green yesterday, now (after Laura's PR?) the EU law notebook fails on Ubuntu. @cwmeijer any idea why?

@elboyran
Update dashboard readme.md
465f3eb 
Make the description more precise.
@elboyran
Update tutorials README.md
fae75cd 
added link to the dashboard
@elboyran
Update dashboard readme.md
d286040 
make the links to the tutorials page more focused.
@cwmeijer
Copy link
Member

cwmeijer commented Oct 29, 2024 •
edited
Loading

The error is:
"RuntimeError: operator torchvision::nms does not exist" while importing from torchvision.
However, all of the systems have the same torchvision version (0.18.1).
Pytorch-lightning versions are the same for all 3 as well. Same goes for transformers, which is the package bringing in torchvision as a dependency, all have version 4.46. No clue what is causing this.

@elboyran
Copy link
Contributor Author

@loostrum would you have time to give it a go (review and hopefully error fix)?

@cwmeijer
Copy link
Member

or @SarahAlidoost for that matter as she managed to fix a possibly similar issue a few weeks back. Whoever of you has time for this.

@loostrum
Copy link
Member

I'm looking into it now. I do see that on ubuntu, the last passing run had an older version of transformers (4.45.2 vs 4.46.0). the 4.46.0 release of transformers was removed from pypi because of some issue with python 3.8, but that's not the version we're using. Just to be sure I've restarted the workflow, which is now using transformers 4.46.1. If that doesn't work, I'll try pinning to <4.46.0

@loostrum
Copy link
Member

Pinning to <4.46 worked 🎉

cwmeijer
cwmeijer approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@cwmeijer cwmeijer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great additions! Excellent idea to have these icons for the dashboard supported cases!

dianna/dashboard/readme.md Outdated Show resolved Hide resolved
@cwmeijer cwmeijer merged commit 8480543 into main Oct 30, 2024
18 checks passed
@cwmeijer cwmeijer deleted the 865-Updating-READMEs-issues-815-863 branch October 30, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwmeijer cwmeijer cwmeijer approved these changes

@loostrum loostrum Awaiting requested review from loostrum

Assignees

@elboyran elboyran

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use collapsed sections in main and tutorial README Update dashboard and main README
3 participants
@elboyran @loostrum @cwmeijer