Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXP: switch to using calc-full-gather.py #18

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Conversation

ctb
Copy link
Member

@ctb ctb commented Jan 28, 2024

This PR switches slainte over to using calc-full-gather.py from https://github.com/ctb/2024-calc-full-gather / sourmash-bio/sourmash_plugin_branchwater#187, which does not run a whole new gather with a picklist, but instead calculates the columns starting from the fastgather output.

This has the advantage of being lower memory and faster, per sourmash-bio/sourmash#2950. This is especially true for large nasty rumen samples, ugh.

Before this gets merged, we would need to fix calc-full-gather to work with multiple databases, among perhaps other things.

@ctb
Copy link
Member Author

ctb commented Jan 29, 2024

This PR also triggered sourmash-bio/sourmash#2952 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant