Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make linearly executing workers start at different positions #286

Merged
merged 7 commits into from
Oct 11, 2024

Conversation

nck-mlcnv
Copy link
Contributor

This pull request makes changes so that multiple workers that execute the same queries linearly, start at different positions.
The starting positions are equally distanced from each other.

Query Handling Enhancements:

Query Selector Improvements:

Worker Initialization Fixes:

Bug Fixes:

Testing Enhancements:

@nck-mlcnv nck-mlcnv self-assigned this Oct 1, 2024
@nck-mlcnv nck-mlcnv linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link
Member

@bigerl bigerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR. Changes look mostly good. There is just one spot where I am a little confused. Only, I am not too fond of the -1 initialization of getCurrentIndex(). Still, I don't have a better solution at hand ATM.

@nck-mlcnv nck-mlcnv requested a review from bigerl October 7, 2024 14:14
@nck-mlcnv nck-mlcnv merged commit 3b0633b into main Oct 11, 2024
3 checks passed
@nck-mlcnv nck-mlcnv deleted the feature/spaced-start branch October 11, 2024 10:21
@nck-mlcnv nck-mlcnv restored the feature/spaced-start branch October 11, 2024 14:46
@nck-mlcnv nck-mlcnv deleted the feature/spaced-start branch October 14, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the workers start at different queries
2 participants