Add options request #702
Merged
Add options request #702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brian Downs <[email protected]>
Signed-off-by: Brian Downs <[email protected]>
Jason2605
approved these changes
Nov 21, 2023
| @@ -12,7 +12,6 @@ | |||
| #include "log.h" | |||
| #include "http/http.h" | |||
| #include "path.h" | |||
| #include "c.h" | |||
There was a problem hiding this comment.
Not sure if this was intentional but we can probably remove the C module in it's entirety now to be honest. Can be done as a diff PR tho I guess.
Thanks for this!
There was a problem hiding this comment.
It was included twice so I figured I'd remove one. I can get a pr in to remove the c module soon.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options request
What's Changed:
Adds the ability to send HTTP OPTIONS requests. I didn't add tests as there's no good way of testing it t the moment. Tested manually.
Type of Change:
Housekeeping:
Screenshots (If Applicable):