Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an issue with internal table type #707

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix an issue with internal table type #707

merged 2 commits into from
Dec 1, 2023

Conversation

Jason2605
Copy link
Member

Internal Table

Resolves: #706

What's Changed:

Reset internal table type to fix an issue with the interned strings

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

@Jason2605 Jason2605 added the bug fix Fixes a bug within the codebase label Dec 1, 2023
@Jason2605 Jason2605 self-assigned this Dec 1, 2023
@Jason2605
Copy link
Member Author

This will need to be applied to sets / dicts too

Copy link
Contributor

@briandowns briandowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What sneaky bug.

@Jason2605
Copy link
Member Author

Yeah was really nasty, found it while doing advent of code lol

@Jason2605 Jason2605 merged commit 4747121 into develop Dec 1, 2023
8 checks passed
@Jason2605 Jason2605 deleted the feature/table branch December 1, 2023 17:32
@briandowns
Copy link
Contributor

That's probably a great way to flush out bugs and figure out new use cases for language features or new stdlib modules.

@Jason2605 Jason2605 mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes a bug within the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Memory issue with strings
2 participants