Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selector 组件建议增加点击蒙层关闭 #64

Closed
zlab opened this issue May 5, 2018 · 4 comments
Closed

Selector 组件建议增加点击蒙层关闭 #64

zlab opened this issue May 5, 2018 · 4 comments
Assignees
@xxyan0205
Labels
discuss Need discuss feature New feature or request
Milestone
v1.3.x

Comments

@zlab
Copy link

zlab commented May 5, 2018

mand-mobile version/项目版本
1.1.0
@zlab
Copy link
Author

zlab commented May 5, 2018

有蒙层的组件，都应该支持点蒙层关闭这个选项吧

@xxyan0205 xxyan0205 added the discuss Need discuss label May 6, 2018
@xxyan0205
Copy link
Collaborator

如selector这类组件因存在确认选中和撤销选中这种交互方式，但点击蒙层关闭这个动作因为无法区分是“确认”或“取消”，故将蒙层关闭禁止需用户主动触发某种指定动作。

@shoyuf
Copy link

shoyuf commented May 9, 2018

点击灰色蒙层应该是默认取消的交互吧，不然的话整个组件的交互很不统一，另外 ActionSheet 和 Selector 的功能是否重合度太高了？

@xxyan0205
Copy link
Collaborator

后面迭代中会把默认取消加上。
ActionSheet 和 Selector 本来从功能上区分是前者处理动作，后者处理数据选择，但目前ActionSheet的api设计的不太适当，导致两者重复度，后期可能会提供单例形式。

@xxyan0205 xxyan0205 added the feature New feature or request label May 9, 2018
@xxyan0205 xxyan0205 added this to the v1.3.x milestone May 11, 2018
xxyan0205 added a commit that referenced this issue May 13, 2018
@xxyan0205
feature:add maskClosable prop #64
47b3456
@xxyan0205 xxyan0205 self-assigned this May 14, 2018
moyus pushed a commit that referenced this issue May 28, 2018
@xxyan0205 @moyus
Feature issue 64/75/77 (#90)
943e5be 
* feature(picker):reset picker when cancel

* feature:add maskClosable prop #64

* fix(date-picker):amend defaultDate according to minDate and maxDate #75

* feature(cashier):update channel display logic #77

* feat(tab-picker): add revoke operation feature  when user click the cancel button

* feat(tab-pciker): add async casacade tabpicker initial feature

* feature(action-sheet & selector):add max-height limit prop #86

* fix(tab-picker): recursion breakpoints continue

* fix(cashier):fix unit test error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xxyan0205 xxyan0205

Labels
discuss Need discuss feature New feature or request
Projects
None yet
Milestone
v1.3.x
Development

No branches or pull requests
3 participants
@zlab @xxyan0205 @shoyuf