Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update dependencies and adjust code to the new API #355

Merged
merged 5 commits into from
Jan 8, 2019

Conversation

kybarg
Copy link
Collaborator

@kybarg kybarg commented Jan 6, 2019

Highlights

  1. Updated webpack to version 4
  2. Removed webpack-blocks dependency in favor of plain config file
  3. Updated babel
  4. Dropped support for Node.js 6
  5. Removed unused dependencies

Fixes #347, #349

@diegohaz I think using webpack-blocks adds more dependencies and complexity to the part that barely changes during version life cycle, that's why I deleted it, moreover it is not supported enough lately.
if you approve, will work on providing PRs for redux and redux-ssr branches.

@kybarg kybarg changed the title Update dependencies and adjust code to the new API Update dependencies and adjust code to the new API (WIP) Jan 6, 2019
@codecov-io
Copy link

codecov-io commented Jan 6, 2019

Codecov Report

Merging #355 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #355   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          43     43           
  Lines         295    297    +2     
  Branches       57     57           
=====================================
+ Hits          295    297    +2
Impacted Files Coverage Δ
src-example/components/pages/NotFoundPage/index.js 100% <ø> (ø) ⬆️
...-example/components/organisms/FeatureList/index.js 100% <ø> (ø) ⬆️
src-example/components/organisms/Hero/index.js 100% <ø> (ø) ⬆️
src-example/components/pages/SamplePage/index.js 100% <ø> (ø) ⬆️
src-example/components/pages/HomePage/index.js 100% <ø> (ø) ⬆️
src-example/components/organisms/Footer/index.js 100% <ø> (ø) ⬆️
...c-example/components/molecules/IconButton/index.js 100% <100%> (ø) ⬆️
src-example/components/molecules/Slider/index.js 100% <100%> (ø) ⬆️
src-example/components/atoms/Input/index.js 100% <100%> (ø) ⬆️
src-example/components/molecules/IconLink/index.js 100% <100%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e52205c...e759f04. Read the comment docs.

@kybarg kybarg changed the title Update dependencies and adjust code to the new API (WIP) Update dependencies and adjust code to the new API Jan 6, 2019
@kybarg kybarg changed the title Update dependencies and adjust code to the new API [master] Update dependencies and adjust code to the new API Jan 6, 2019
@diegohaz
Copy link
Owner

diegohaz commented Jan 7, 2019

Thank you so much @kybarg

Only one thing: are all those babel plugins necessary?

@kybarg
Copy link
Collaborator Author

kybarg commented Jan 7, 2019

@diegohaz babel since version 7 has broken everything into separate plugins... I guess to be able to drop them easyly when all features are implemented natively

Copy link
Owner

@diegohaz diegohaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! ✨

@diegohaz diegohaz merged commit dc52232 into diegohaz:master Jan 8, 2019
@EricWVGG
Copy link

Thank you @kybarg, looking forward to the redux-ssr branch.

@Sashkan
Copy link

Sashkan commented Jul 16, 2019

@kybarg Any updates on the portage to redux-ssr ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to webpack 4 & the new webpack blocks so that we can get ready for storybook 4
5 participants