Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating all dependencies, with tests #356

Merged
merged 27 commits into from
Aug 29, 2019
Merged

Conversation

BrenoMazieiro
Copy link
Collaborator

Like @kybarg

Highlights

  • Updated webpack to version 4
  • Removed webpack-blocks dependency in favor of plain config file
  • Updated babel
  • Dropped support for Node.js 6
  • Removed unused dependencies

Plus

  • react: 16.8.5
  • react-dom: 16.8.5
  • react-router-dom: 5.0.0
  • react-redux: 6.0.1
  • redux: 4.0.1
  • redux-form 8.1.0
  • redux-saga: 1.0.2
  • redux-saga-thunk: 0.7.3
  • styled-components: 4.2.0
  • and more...

@codecov-io
Copy link

codecov-io commented Mar 29, 2019

Codecov Report

Merging #356 into redux will decrease coverage by 0.5%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            redux     #356      +/-   ##
==========================================
- Coverage   99.72%   99.22%   -0.51%     
==========================================
  Files          73       72       -1     
  Lines         735      773      +38     
  Branches      178      175       -3     
==========================================
+ Hits          733      767      +34     
- Misses          2        6       +4
Impacted Files Coverage Δ
...-example/components/organisms/FeatureList/index.js 100% <ø> (ø) ⬆️
src-example/components/organisms/Hero/index.js 100% <ø> (ø) ⬆️
src-example/components/pages/HomePage/index.js 100% <ø> (ø) ⬆️
src-example/store/gtm/sagas.js 100% <ø> (ø) ⬆️
src-example/store/resource/reducer.js 94.44% <ø> (ø) ⬆️
src-example/components/pages/NotFoundPage/index.js 100% <ø> (ø) ⬆️
src-example/components/organisms/Footer/index.js 100% <ø> (ø) ⬆️
...c-example/components/molecules/IconButton/index.js 100% <100%> (ø) ⬆️
src-example/components/atoms/Block/index.js 100% <100%> (ø) ⬆️
...c-example/components/organisms/LoginModal/index.js 100% <100%> (ø) ⬆️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94132ca...15a11c2. Read the comment docs.

@BrenoMazieiro
Copy link
Collaborator Author

Well, that is it!
Every package is updated!
Coverage at 99%

BUT

Things I was not able to do:

1-) When running the test I've got warnings like:
It looks like you've wrapped styled() around your React component (Icon), but the classNa
me prop is not being passed down to a child. No styles will be rendered unless className is com
posed within your React component.

2-) At console Browser there is a warning:
React-Hot-Loader: react-🔥-dom patch is not detected. React 16.6+ features may not work.

3-) When update storybook/react and storybook/addon-actions to 5.0.5:
Ive got a error running "yarn storybook:example"
Something about the webpack.config file inside private folder.

anyone willing to help me?
Thanks guys!

@BrenoMazieiro BrenoMazieiro reopened this Mar 29, 2019
@gfsd3v
Copy link

gfsd3v commented Apr 1, 2019

Well, that is it!
Every package is updated!
Coverage at 99%

BUT

Things I was not able to do:

1-) When running the test I've got warnings like:
It looks like you've wrapped styled() around your React component (Icon), but the classNa
me prop is not being passed down to a child. No styles will be rendered unless className is com
posed within your React component.

2-) At console Browser there is a warning:
React-Hot-Loader: react-🔥-dom patch is not detected. React 16.6+ features may not work.

3-) When update storybook/react and storybook/addon-actions to 5.0.5:
Ive got a error running "yarn storybook:example"
Something about the webpack.config file inside private folder.

anyone willing to help me?
Thanks guys!

I'm also having problems with the storybook thing, but what u did would really be helpful, someone should review and release this PR.

@kybarg
Copy link
Collaborator

kybarg commented Apr 4, 2019

@BrenoMazieiro Thank you for you contribution, going to check this PR over the weekend.

@gfsd3v
Copy link

gfsd3v commented Apr 25, 2019

Hey @BrenoMazieiro, I was able to fix the webpack configuration for the storybook update, don't know if I should wait for this PR to be released to open my PR or if I should do it now, what are u thoughts on it ?

@BrenoMazieiro
Copy link
Collaborator Author

BrenoMazieiro commented Apr 25, 2019

I believe it depends, if you made it from my PR, you should wait, because maybe soon enough we will have an answer on mine. If you made from redux branch, then open a PR.
Anyway I'm curious to know how it solved the problem!

@BrenoMazieiro
Copy link
Collaborator Author

Maybe @diegohaz or @kybarg can help us with it!

@diegohaz
Copy link
Owner

@gfsd3v if your PR is based on @BrenoMazieiro's branch, you can open a new PR with his commits included.

@BrenoMazieiro
Copy link
Collaborator Author

@gfsd3v and @diegohaz, updated, all errors and warnings is now ok, and storybook it is in its last version.

@kybarg
Copy link
Collaborator

kybarg commented Aug 28, 2019

@diegohaz everything looks perfect so far
@BrenoMazieiro thanks for effort, I think gonna merge this in couple days

Copy link
Collaborator

@kybarg kybarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's ready for merge, thanks to
@BrenoMazieiro
@gfsd3v

@kybarg kybarg merged commit b08a4c5 into diegohaz:redux Aug 29, 2019
@diegohaz
Copy link
Owner

Thank you for the awesome work, @BrenoMazieiro (sent you an invitation to be collaborator on this project)! And thank you @kybarg for reviewing this! ❤️

@EricWVGG
Copy link

Is anyone actively working on the Redux-SSR branch?

@diegohaz
Copy link
Owner

@EricWVGG Not that I’m aware of

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants