-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating all dependencies, with tests #356
Conversation
Codecov Report
@@ Coverage Diff @@
## redux #356 +/- ##
==========================================
- Coverage 99.72% 99.22% -0.51%
==========================================
Files 73 72 -1
Lines 735 773 +38
Branches 178 175 -3
==========================================
+ Hits 733 767 +34
- Misses 2 6 +4
Continue to review full report at Codecov.
|
Well, that is it! BUT Things I was not able to do: 1-) When running the test I've got warnings like: 2-) At console Browser there is a warning: 3-) When update storybook/react and storybook/addon-actions to 5.0.5: anyone willing to help me? |
I'm also having problems with the storybook thing, but what u did would really be helpful, someone should review and release this PR. |
@BrenoMazieiro Thank you for you contribution, going to check this PR over the weekend. |
Hey @BrenoMazieiro, I was able to fix the webpack configuration for the storybook update, don't know if I should wait for this PR to be released to open my PR or if I should do it now, what are u thoughts on it ? |
I believe it depends, if you made it from my PR, you should wait, because maybe soon enough we will have an answer on mine. If you made from redux branch, then open a PR. |
@gfsd3v if your PR is based on @BrenoMazieiro's branch, you can open a new PR with his commits included. |
@diegohaz everything looks perfect so far |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's ready for merge, thanks to
@BrenoMazieiro
@gfsd3v
Thank you for the awesome work, @BrenoMazieiro (sent you an invitation to be collaborator on this project)! And thank you @kybarg for reviewing this! ❤️ |
Is anyone actively working on the Redux-SSR branch? |
@EricWVGG Not that I’m aware of |
Like @kybarg
Highlights
Plus