-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: font selection regression #2747
fix: font selection regression #2747
Conversation
🦋 Changeset detectedLatest commit: 89e8f82 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@diegomura could you please merge this? |
@diegomura Plase merge this ! i need :( |
Yes I am using this library as well and right now the fonts are not working correctly. This fix is what I am waiting for! Please merge! |
@websnacks Dear, when can we see the change reflected in the library? I am waiting for this change to upload a code to improve a PDF |
When are the changes going to go up? I need it @diegomura @bdkopen |
I applied these changes, but still couldn't get the bold font back. Instead, to resolve it, I forced the resolution of "@react-pdf/layout" to point to
to your |
@Hatko @websnacks @diegomura I have not implemented @react-pdf/layout in my project This is where I have the problem |
@TomasSalas the fix needs to be applied to the |
@lecstor Could you help me with my project? since I work with NPM and I do not fully understand what you are telling me to be able to use what I need in the texts ?? |
@TomasSalas it looks like you could use this then.. https://www.npmjs.com/package/patch-package You'll need to open Then follow the instructions in |
@TomasSalas have a look at the PR. Did you remove lines 204 to 206? |
I believe If you are using yarn, replace
|
@lecstor yes remove lines 204 to 206 |
@TomasSalas not according to that screenshot in your last comment. These lines should not remain..
|
@lecstor |
@TomasSalas as long as you add the |
I have applied the patch like above, but unfortunately it's still not working (font weight). |
Is it known when the changes will be uploaded? @diegomura @bdkopen |
I am not a maintainer, so I have no control over when this will be merged. |
@bdkopen And do you know who the maintainer is? so I can request his help? |
@diegomura is the primary maintainer. |
update example add tests fix mistakes
@diegomura merge needed |
@diegomura please 🙏🏻 |
@diegomura It's been 2+ months in the last merge. Are you still able to maintain this repo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
I just updated the library and it doesn't work @diegomura |
@TomasSalas it's because it's not released yet. last release is april 25 |
When can we have this in production, I need this change urgently :( @diegomura |
This recent change #2640 appears to have caused a regression where the first font used in a line of text is utilized for the entire line. This includes usage of
fontFamily
,fontWeight
, andfontStyle
.Changes
pickFontFromFontStack
to select fromfontStack
beforelastFont
. This should now properly prioritize fontspackages/layout/tests/text/fontSubstitution.test.js
Related
Example
Before
After