Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 19 #2783

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

React 19 #2783

wants to merge 15 commits into from

Conversation

alexandernanberg
Copy link

@alexandernanberg alexandernanberg commented Jun 12, 2024

Fixes #2756

Copy link

changeset-bot bot commented Jun 12, 2024

🦋 Changeset detected

Latest commit: 7c435eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@react-pdf/renderer Major
@react-pdf/examples Patch
@react-pdf/e2e-node-cjs Patch
@react-pdf/e2e-node-esm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

package.json Outdated
@@ -46,7 +46,6 @@
"@typescript-eslint/parser": "^6.21.0",
"@vitejs/plugin-react": "^4.2.1",
"babel-plugin-add-module-exports": "^1.0.0",
"canvas": "^2.11.2",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completely unable to install this dep, we'll revisit this later

@alexandernanberg alexandernanberg marked this pull request as ready for review June 13, 2024 08:24
@alexandernanberg
Copy link
Author

alexandernanberg commented Jun 13, 2024

Currently both react-reconciler.development.js and react-reconciler.production.js are included in the bundle, which isn't optimal. I don't see any good alternative though, since jsx-runtime in dev requires dev specific APIs of the reconciler

We could move react-reconciler to a dependency and stop inlining it, but that could cause other issues (duplicate deps etc). Another option is to create separate prod and dev bundles, just like React does. Would be annoying to manage with both esm and cjs tho

@joacub
Copy link

joacub commented Sep 22, 2024

no solutions ?

@diegomura
Copy link
Owner

This is a solution for react19 at the expense of dropping support for all other versions for what I understand. Is that correct?

@alexandernanberg
Copy link
Author

Yes, that is my understanding. That said, I've not tested this branch with React 18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compat with react 19
3 participants