Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added Form Annotation support #2845
base: master
Are you sure you want to change the base?
feat: added Form Annotation support #2845
Changes from 16 commits
eee292a
e39acab
51b4493
687aa06
b562369
824d05c
f20153a
33ef422
c36d8c9
24183a0
6264795
e6fa36b
9f68eaa
c6f86f5
49322f8
81b75d2
8aa7a0a
d05e812
a08b945
c7fb5e2
d9a1e84
96e4d7d
7162e6f
3dac42b
ef4fee3
3e6c660
de0c19d
fd6e5f9
43bd666
39cb88a
81dc6fa
e1e3726
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a strong opinion, but would
Form
be more semantic? ForField
I imagine like an input, but this is actually a form wrapperThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @diegomura,
thanks for your response. Let's see what I suggested here in the past: #2845 (comment). 🤔
My initial thought was to align the names with the ones used in
pdfkit
(here). SoTextInput
becomesFormText
,Picker
becomesFormPicker
, and so on. But you made a valid point back in 2022 suggesting we should stick to the native web primitives. I got used to the current names while preparing the PR.Regarding
FormField
: I chose the same name aspdfkit
mainly to align our (react-pdf) and their (pdfkit) docs and keep them similar. I don't know if that's practical.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about something like
FormGroup
? Form rather sounds like the single and complete set of inputs, but they rather are a subsection. E.g., you could separate billing address and shipping address into twogroups
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PhilippBloss,
your suggestion makes sense to me, considering what pdfkit states in their docs as well:
What do you think of
fieldset
(https://developer.mozilla.org/en-US/docs/Web/HTML/Element/fieldset):There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good as well. Would give the decision to @diegomura
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would take over the docs, except @natterstefan has already started with those
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PhilippBloss, I haven't taken care of the docs yet. You can take over the docs if you want to or we can share the task. It's fine for me.
Also thanks for the review. I will try to apply your suggestions tomorrow or at least in the next few days.
Thanks for the ping @diegomura.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of keeping the initial names of these components to keep them aligned with the form annotation methods of
PDFKit
?(src)