Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolve TypeScript error in PDFDownloadLink component react-pdf v4 #2888

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve TypeScript error in PDFDownloadLink component react-pdf v4 #2888

wants to merge 1 commit into from
+4 −1

Conversation

islam-kamel
Copy link

@islam-kamel islam-kamel commented Sep 26, 2024 •
edited
Loading

Fixed #2886

Changes Made:

  • Updated PDFDownloadLinkProps to correctly handle the 'children' prop, allowing for both ReactNode and function types.
  • Ensured compatibility with TypeScript type definitions to prevent type mismatches.
  • Added necessary type assertions to preserve functionality.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 8a04cbc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@islam-kamel islam-kamel mentioned this pull request Sep 26, 2024
Open
@islam-kamel islam-kamel changed the title fix: resolve #2886 TypeScript error in PDFDownloadLink component react-pdf v4 fix: resolve TypeScript error in PDFDownloadLink component react-pdf v4 Sep 26, 2024
@robbycarter
Copy link

Anything i can do to help speed up this PR?

@mamlzy
Copy link

mamlzy commented Oct 18, 2024

@diegomura sorry for tagging you

@fatihgnc
Copy link

fatihgnc commented Nov 7, 2024

I need this PR to be merged...

diegomura
diegomura reviewed Nov 14, 2024
View reviewed changes
packages/renderer/index.d.ts
@@ -495,12 +495,15 @@ declare namespace ReactPDF {
*/
export class PDFViewer extends React.Component<PDFViewerProps> {}

// @ts-ignore
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomura diegomura diegomura left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeScript Error in PDFDownloadLink with React-PDF v4
5 participants
@islam-kamel @robbycarter @mamlzy @fatihgnc @diegomura