Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ungate try_from because it has been stabilized #2010

Merged
merged 16 commits into from
Apr 16, 2019

Conversation

KeenS
Copy link
Contributor

@KeenS KeenS commented Mar 13, 2019

See also rust-lang/rust#58302.
This fixes failures of other CIs

@@ -178,7 +178,8 @@ jobs:
- template: _build/install-rust.yml
parameters:
platform: Linux
rust_version: nightly-2018-11-27
# least nightly release that stabilize try_from
rust_version: nightly-2019-02-26
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated nightly version to pass test. Is this acceptable? To say more, what's the policy of supported nightly version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's fine. This is only the compile tests. We don't officially support nightly, we just bump this periodically as needed to be able to run the compile tests (which require nightly)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

@@ -178,7 +178,8 @@ jobs:
- template: _build/install-rust.yml
parameters:
platform: Linux
rust_version: nightly-2018-11-27
# least nightly release that stabilize try_from
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this comment

@@ -93,7 +93,7 @@
//! You can come ask for help at
//! [gitter.im/diesel-rs/diesel](https://gitter.im/diesel-rs/diesel)

#![cfg_attr(feature = "unstable", feature(specialization, try_from))]
#![cfg_attr(feature = "unstable", feature(specialization))]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the gating on the uses of this feature as well (grep try_from)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try_from has been stabilized (ungated) at nightly but it is still nightly only API.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the FIXME comment to specify which Rust version we can use it?

Copy link
Member

@weiznich weiznich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI says the output of the compile tests changed. That needs to be fixed (Updating the expected output is ok as long as the error messages do not regress)

@@ -1 +1 @@
nightly-2018-11-27
nightly-2019-02-26
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That changes the output of our compile tests, which means you need to go though that errors and adjust them. (There is a script for that)

KeenS and others added 5 commits April 2, 2019 15:19
This version supports `TryFrom` so remove that feature from our unstable
list.
Also fix all new clippy warnings and update the compile test output to
newer compiler versions
@weiznich weiznich mentioned this pull request Apr 14, 2019
@weiznich weiznich merged commit 167e704 into diesel-rs:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants