Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obsolete - Internal-only breaking changes #1096

Closed
wants to merge 15 commits into from
Closed

obsolete - Internal-only breaking changes #1096

wants to merge 15 commits into from

Commits on Jan 2, 2023

  1. Remove crufty and internally-unused methods from Formatter.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    cb0a4a4 View commit details
    Browse the repository at this point in the history

  2. Remove FormatterStep.Strict, an unnecessary implementation detail.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    9520000 View commit details
    Browse the repository at this point in the history

  3. Moved PaddedCell.DirtyState to its own top-level class with new met… 

    …hods.
    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    e563c9d View commit details
    Browse the repository at this point in the history

  4. Removed rootDir property Formatter and its builder because it was… 

    … only used to annnotate errors, which will now done by the lint phase.
    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    6197210 View commit details
    Browse the repository at this point in the history

  5. Remove the FormatExceptionPolicy from the Formatter because it wi… 

    …ll become part of linting,
    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    1eea0fc View commit details
    Browse the repository at this point in the history

  6. Temporarily disable ErrorShouldRethrowTest because Formatter does… 

    …n't respect `FormatExceptionPolicy` anymore.
    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    0bd78cc View commit details
    Browse the repository at this point in the history

  7. Refactor PipeStepPair so that it can detect lost tags within our new … 

    …lint paradigm. The old way made it impossible to detect lost tags if `apply` always succeeds.
    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    480e555 View commit details
    Browse the repository at this point in the history

  8. Improve the test harnesses to prepare for linting.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    e61d7e1 View commit details
    Browse the repository at this point in the history

  9. Remove deprecated methods.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    6a0c81b View commit details
    Browse the repository at this point in the history

  10. Rename PipeStepPair to FenceStep since there isn't actually a pai… 

    …r anymore.
    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    cc01036 View commit details
    Browse the repository at this point in the history

  11. Update the changelog.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    481aa49 View commit details
    Browse the repository at this point in the history

  12. Update changelog.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    e2fdef5 View commit details
    Browse the repository at this point in the history

  13. Better variable names for the PipeStepPair -> FenceStep rename.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    2d8fe6d View commit details
    Browse the repository at this point in the history

  14. Fix prettier test exception message assertion.

    @nedtwigg
    nedtwigg committed Jan 2, 2023
    Configuration menu
    Copy the full SHA
    2991b26 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. Fix spotbugs warnings in FenceStep.

    @nedtwigg
    nedtwigg committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    01f73c0 View commit details
    Browse the repository at this point in the history