Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixing #427 #434

Merged
merged 2 commits into from
Aug 20, 2019
Merged

Try fixing #427 #434

merged 2 commits into from
Aug 20, 2019

Conversation

ZacSweers
Copy link
Contributor

This attempts to fix #427 with its suggested solution. Kicking this to CI as I'm not able to get tests to pass locally for this project right now for some reason (I suspect it's due to my local jdk version)

@ZacSweers
Copy link
Contributor Author

Also - is there a recommended pattern for installing to mavenLocal to test in other projects?

@nedtwigg
Copy link
Member

@nedtwigg
Copy link
Member

I just cleared the travis cache and restarted the build. If it works now, then the problem was #429 all along. It seems that the newer gradle versions are less friendly to our TestProvisioner.

@ZacSweers
Copy link
Contributor Author

ZacSweers commented Aug 20, 2019

Verified locally that no more warnings are produced when I try in my side project - https://github.com/zacsweers/catchup, and also still works if I change some formatting in files

@nedtwigg
Copy link
Member

Great! Thanks for the broad modernization push Zac!

@nedtwigg nedtwigg merged commit e558cda into diffplug:master Aug 20, 2019
@ZacSweers ZacSweers deleted the z/fixGradleWarning branch August 20, 2019 04:22
@ZacSweers
Copy link
Contributor Author

Happy to help!

@nedtwigg
Copy link
Member

Released in 3.24.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gradle issue: Using the incremental task API without declaring any outputs has been deprecated.
2 participants