ci: refactor node setup into a composite action to remove duplication

digabi · Nov 15, 2024 · 8733dcd · 8733dcd
1 parent 4df0e2a
commit 8733dcd
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 24 deletions.
diff --git a/.github/actions/node-setup/action.yml b/.github/actions/node-setup/action.yml
@@ -0,0 +1,15 @@
+name: Node.js Setup
+description: Sets up Node.js and installs dependencies.
+
+runs:
+  using: composite
+  steps:
+    - name: Setup Node.js
+      uses: actions/setup-node@v4
+      with:
+        node-version-file: '.nvmrc'
+        cache: 'npm'
+
+    - name: Install Dependencies
+      shell: bash
+      run: npm ci
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -13,22 +13,16 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-
-      - name: Install nodejs
-        uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-          cache: 'npm'
+
+      - name: Node.js Setup
+        uses: ./.github/actions/node-setup
 
       - name: Restore puppeteer cache
         uses: actions/cache@v4
         with:
           path: ~/.cache/puppeteer
           key: ${{ runner.os }}-${{ hashFiles('package-lock.json') }}
 
-      - name: Install dependencies
-        run: npm ci
-
       - run: npm rebuild full-icu
 
       - name: Run Jest Tests
@@ -38,15 +32,9 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-
-      - name: Install nodejs
-        uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-          cache: 'npm'
 
-      - name: Install dependencies
-        run: npm ci
+      - name: Node.js Setup
+        uses: ./.github/actions/node-setup
 
       - name: Install Playwright Browsers
         run: npx playwright install --with-deps
@@ -58,20 +46,16 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-
-      - name: Install nodejs
-        uses: actions/setup-node@v4
-        with:
-          node-version-file: '.nvmrc'
-          cache: 'npm'
+
+      - name: Node.js Setup
+        uses: ./.github/actions/node-setup
 
       - name: Restore puppeteer cache
         uses: actions/cache@v4
         with:
           path: ~/.cache/puppeteer
           key: ${{ runner.os }}-${{ hashFiles('package-lock.json') }}
 
-      - run: npm ci
       - name: "run linter"
         env:
           NODE_OPTIONS: "--max_old_space_size=4096"