Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Refactor probes and add more health checks #1159
base: main
Are you sure you want to change the base?
chore: Refactor probes and add more health checks #1159
Changes from all commits
1317e97
51c3515
b25034e
42326d1
a275c12
ddf0ce7
d58b8e4
1cafcdf
3996060
8889b77
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing registration of dependency health checks with
'dependencies'
tag.The endpoints
/startup
,/readiness
, and/health
are configured to report on health checks tagged with"dependencies"
, but no health checks are registered with this tag in the provided code. As a result, these endpoints may not return any checks, leading to incomplete health status reports.Consider registering health checks for your dependencies (e.g., Redis, PostgreSQL) and tagging them with
"dependencies"
. Here's how you might update your health check registration:Ensure that the connection strings
"Redis"
and"PostgreSQL"
are correctly configured in yourappsettings.json
or environment variables.Also applies to: 216-220, 221-225
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But these are registered in InfrastructureExtensions though right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arealmaas, you're absolutely correct. The dependency health checks are registered in
InfrastructureExtensions.cs
with the'dependencies'
tag. I apologize for the oversight in my previous comment.🐰🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries mate! We all do mistakes 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arealmaas, thank you for your understanding! 😊
(_/)
( ^.^)
/(")(")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make me a haiku poem about the code changes in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arealmaas,
Sure, here's a haiku about the code changes in this file:
New health checks in place,
Startup, liveness endpoints,
Dependencies checked.