-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ensure jq exists for container app job verifier #1217
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the script Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- .github/tools/containerAppJobVerifier.sh (1 hunks)
🧰 Additional context used
🪛 Shellcheck
.github/tools/containerAppJobVerifier.sh
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
(SC2069)
🔇 Additional comments (1)
.github/tools/containerAppJobVerifier.sh (1)
Line range hint
7-78
: Approve the overall script structure and functionalityThe main body of the script is well-structured and implements the job verification logic effectively. Key points:
- Proper parameter checking and usage instructions are in place.
- The use of
jq
for parsing JSON output from Azure CLI is appropriate.- The loop for checking job status includes a sleep to prevent excessive API calls.
- Error handling for various scenarios (e.g., job not found, job failed) is implemented.
The script effectively achieves its purpose of verifying the success of a job execution in Azure Container Apps.
🧰 Tools
🪛 Shellcheck
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
[warning] 1-1: To redirect stdout+stderr, 2>&1 must be last (or use '{ cmd > file; } 2>&1' to clarify).
(SC2069)
Description
Related Issue(s)
Verification
Documentation
docs
-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)Summary by CodeRabbit
New Features
jq
command-line tool if not present.Bug Fixes