fix: close idle connections when stopping FastifyController #857
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node 18, calling
HTTP.Server.close()
does not close idle connections, which resulted in some undesirable behavior in the server lifecycle in CoMapeo Mobile (see digidem/comapeo-mobile#748 for more context). In Node >=19, closing the server does the equivalent work of ofcloseIdleConnections()
internally.This PR explicitly calls
closeIdleConnections()
when stopping the server, at the guidance of the Node docs:There's probably an easy way to test this but wasn't immediately sure of how to do it. Happy to add one with some guidance.