feat: audio recording #381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edesign-edit-observation
…design-edit-observation
bohdanprog
reviewed
May 28, 2024
src/frontend/screens/Audio/bottomSheet/AudioRecordingDeleteBottomSheet.tsx
Outdated
Show resolved
Hide resolved
CDFN
force-pushed
the
feat/audio-recording-screen
branch
from
9e2859f
to
525bc74
Compare
CDFN
commented
May 29, 2024
| elapsedTime: SharedValue<number>; | ||
| } | ||
|
|
||
| export function convertMsToTime(ms: number) { |
There was a problem hiding this comment.
I don't like how it looks but for context: Bohdan had issues with passing functions from react-intl into reanimated UI thread, hence this method.
CDFN
commented
May 29, 2024
src/frontend/screens/Audio/bottomSheet/AudioRecordingDeleteBottomSheet.tsx
Outdated
Show resolved
Hide resolved
CDFN
commented
May 29, 2024
src/frontend/screens/Audio/bottomSheet/AudioRecordingSuccessBottomSheet.tsx
Outdated
Show resolved
Hide resolved
CDFN
commented
May 29, 2024
src/frontend/screens/Audio/bottomSheet/AudioShareBottomSheet.tsx
Outdated
Show resolved
Hide resolved
CDFN
commented
May 29, 2024
Comment on lines
+108
to
+109
| createdAt: 0, | ||
| duration: 0, |
There was a problem hiding this comment.
We're unable to save metadata with audio recording, hence mock values for now. Possibly related to #378
CDFN
commented
May 29, 2024
CDFN
commented
May 29, 2024
This was referenced Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds most of recording feature which is subject of #360 and #361.