Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deleting audio files from existing observations #388

Open
wants to merge 2 commits into
base: feat/audio-recording-screen
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/frontend/hooks/server/observations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import {
useMutation,
useSuspenseQuery,
useQueryClient,
useQuery,
} from '@tanstack/react-query';
import {ObservationValue} from '@mapeo/schema';
import {useActiveProject} from '../../contexts/ActiveProjectContext';
Expand Down Expand Up @@ -33,6 +34,19 @@ export function useObservation(observationId: string) {
});
}

export function useMaybeObservation(observationId?: string) {
const project = useActiveProject();

return useQuery({
queryKey: [OBSERVATION_KEY, observationId],
queryFn: async () => {
if (!project) throw new Error('Project instance does not exist');
return project.observation.getByDocId(observationId!);
},
enabled: !!observationId,
});
}

export function useCreateObservation() {
const queryClient = useQueryClient();
const project = useActiveProject();
Expand Down
6 changes: 4 additions & 2 deletions src/frontend/screens/Audio/AudioPlaybackScreen.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import {
NEW_DARK_GREY,
WHITE,
} from '../../lib/styles.ts';
import {StatusBar} from 'expo-status-bar';
import React from 'react';
import {Duration} from 'luxon';
import PlayArrow from '../../images/playArrow.svg';
Expand Down Expand Up @@ -55,7 +54,8 @@ export const AudioPlaybackScreen: React.FC<
});

const navigation = useNavigationFromRoot();
const {recordingUri, previewOnly} = params.route.params;
const {recordingUri, previewOnly, attachmentId, observationId} =
params.route.params;
const observation = useDraftObservation();

const {
Expand Down Expand Up @@ -133,6 +133,8 @@ export const AudioPlaybackScreen: React.FC<
isOpen={isOpenDeleteBottomSheet}
closeSheet={closeDeleteBottomSheet}
sheetRef={deleteAudioSheetRef}
observationId={observationId}
attachmentId={attachmentId}
recordingUri={recordingUri}
previewOnly={previewOnly}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,37 +12,69 @@ import {BottomSheetModalMethods} from '@gorhom/bottom-sheet/lib/typescript/types
import * as RNFS from '@dr.pogodin/react-native-fs';
import {useNavigationFromRoot} from '../../../hooks/useNavigationWithTypes.ts';
import {useDraftObservation} from '../../../hooks/useDraftObservation.ts';
import {
useEditObservation,
useMaybeObservation,
} from '../../../hooks/server/observations.ts';

interface AudioRecordingDeleteBottomSheet {
sheetRef: React.RefObject<BottomSheetModalMethods>;
isOpen: boolean;
recordingUri: string;
previewOnly?: boolean;
attachmentId?: string;
observationId?: string;
closeSheet: () => void;
}

export const AudioRecordingDeleteBottomSheet: FC<
AudioRecordingDeleteBottomSheet
> = ({sheetRef, isOpen, closeSheet, recordingUri, previewOnly}) => {
> = ({
sheetRef,
isOpen,
closeSheet,
recordingUri,
attachmentId,
observationId,
previewOnly,
}) => {
const {formatMessage} = useIntl();
const navigation = useNavigationFromRoot();
const observation = useDraftObservation();
const draftObservation = useDraftObservation();
const {data: observation, isPending: observationPending} =
useMaybeObservation(observationId);
const editObservation = useEditObservation();

const handleRecordingDelete = async () => {
closeSheet();
if (attachmentId && observationId) {
editObservation.mutate({
versionId: observation!.versionId,
value: {
...observation!,
attachments: observation!.attachments.filter(
attachment => attachment.driveDiscoveryId !== attachmentId,
),
},
});
navigation.goBack();
return;
}
if (previewOnly) {
observation.removeAudioRecording(recordingUri);
draftObservation.removeAudioRecording(recordingUri);
navigation.goBack();
} else {
await RNFS.unlink(new URL(recordingUri).pathname);
navigation.replace('ObservationEdit');
return;
}
await RNFS.unlink(new URL(recordingUri).pathname);
navigation.replace('ObservationEdit');
};

return (
<BottomSheetModal ref={sheetRef} isOpen={isOpen}>
<BottomSheetContent
loading={false}
loading={
!!attachmentId && (observationPending || editObservation.isPending)
}
buttonConfigs={[
{
variation: 'filled',
Expand Down
2 changes: 2 additions & 0 deletions src/frontend/screens/Observation/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ export const ObservationScreen: NativeNavigationComponent<'Observation'> = ({
uri: attachmentData.url,
createdAt: 0,
duration: 0,
attachmentId: attachmentData.driveDiscoveryId,
observationId: observationId,
};
})}
photos={photoAttachmentsUrls.map(attachmentData => {
Expand Down
5 changes: 3 additions & 2 deletions src/frontend/sharedComponents/Thumbnail/MediaScrollView.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@ import {Photo} from '../../contexts/PhotoPromiseContext/types';
import {PhotoThumbnail} from './PhotoThumbnail';
import {AudioThumbnail} from './AudioThumbnail';
import {useNavigationFromRoot} from '../../hooks/useNavigationWithTypes.ts';
import {Recording} from 'expo-av/build/Audio/Recording';
import {AudioRecording} from '../../sharedTypes/audio.ts';

const spacing = 10;
const minSize = 150;

interface MediaScrollView {
photos: (Partial<Photo> | undefined)[];
audioRecordings: any[];
audioRecordings: (AudioRecording | undefined)[];
observationId?: string;
}

Expand Down Expand Up @@ -48,6 +47,8 @@ export const MediaScrollView: FC<MediaScrollView> = props => {
screen: 'Playback',
params: {
recordingUri: recording.uri,
observationId: recording.observationId,
attachmentId: recording.attachmentId,
previewOnly: true,
},
});
Expand Down
2 changes: 2 additions & 0 deletions src/frontend/sharedTypes/audio.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@ export interface AudioRecording {
uri: string;
createdAt: number;
duration: number;
attachmentId?: string;
observationId?: string;
}
2 changes: 2 additions & 0 deletions src/frontend/sharedTypes/navigation.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ export type AudioStackParamList = {
Playback: {
previewOnly?: boolean;
recordingUri: string;
attachmentId?: string;
observationId?: string;
};
};

Expand Down
Loading