Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hardcoded pip dependency versions #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dhenschen
Copy link

Prior to this pull request, The Travis CI and local unit test suites were failing (see https://travis-ci.org/digidotcom/python-wpa-supplicant/builds/454696189). All of the unit test failures were related to version incompatibility issues with new pip dependencies.

This pull request adds explicit package versions of click and Twisted. The versions used are from the most passing Travis CI job at: https://travis-ci.org/digidotcom/python-wpa-supplicant/builds/248812490

Prior to this commit, The Travis CI and local unit test
suites were failing. All of the unit test failures were
related to version incompatibility issues with new pip
dependencies.

This commit adds explicit package versions of click and
Twisted. The versions used are from the most passing
Travis CI job at:
https://travis-ci.org/digidotcom/python-wpa-supplicant/builds/248812490
@rogerlucas-veea
Copy link

rogerlucas-veea commented Feb 29, 2020

Please can you merge this? The code is broken at the moment as the default packages pulled in are currently click 7.0 and Twisted 19.10.0...
When I run the CLI, I get the following errors reported:

Traceback (most recent call last):
  File "/home/pi/.local/lib/python3.7/site-packages/wpa_supplicant/cli.py", line 85, in <module>
    @click.pass_context
  File "/usr/lib/python3/dist-packages/click/decorators.py", line 151, in decorator
    _param_memo(f, ArgumentClass(param_decls, **attrs))
  File "/usr/lib/python3/dist-packages/click/core.py", line 1808, in __init__
    Parameter.__init__(self, param_decls, required=required, **attrs)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1338, in __init__
    self._parse_decls(param_decls or (), expose_value)
  File "/usr/lib/python3/dist-packages/click/core.py", line 1841, in _parse_decls
    'parameter declaration, got %d' % len(decls))
TypeError: Arguments take exactly one parameter declaration, got 2

With click 6.7 and twisted 17.5.0, it works.

Click 6.7 resolves the above error. Other errors occur later such as:

Interface(Path: /fi/w1/wpa_supplicant1/Interfaces/1, Name: wlan0, State: disconnected)
OK
Traceback (most recent call last):
  File "/home/pi/.local/lib/python3.7/site-packages/wpa_supplicant/cli.py", line 277, in <module>
    run()
  File "/home/pi/.local/lib/python3.7/site-packages/wpa_supplicant/cli.py", line 273, in run
    root()
  File "/home/pi/.local/lib/python3.7/site-packages/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/home/pi/.local/lib/python3.7/site-packages/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/home/pi/.local/lib/python3.7/site-packages/click/core.py", line 1066, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/home/pi/.local/lib/python3.7/site-packages/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/pi/.local/lib/python3.7/site-packages/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/home/pi/.local/lib/python3.7/site-packages/wpa_supplicant/cli.py", line 177, in get_interface
    pprint.pprint(supp.get_interface(ifname))
  File "/usr/lib/python3.7/contextlib.py", line 119, in __exit__
    next(self.gen)
  File "/home/pi/.local/lib/python3.7/site-packages/wpa_supplicant/cli.py", line 38, in supplicant
    reactor.sigTerm()
  File "/home/pi/.local/lib/python3.7/site-packages/twisted/internet/base.py", line 696, in sigTerm
    self._exitSignal = args[0]
IndexError: tuple index out of range

which are resolved by installing Twisted 17.5.0.

@posborne
Copy link
Contributor

posborne commented Mar 2, 2020

@brandonmoser Can you help get this merged? ideally we would like a set of active maintainers on this project with the commit bit. Alternatively we can work out where to move the repo / setup a maintained fork outside of this org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants