Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate ghc-9.2.1 builds #335

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

shayne-fletcher
Copy link
Contributor

this PR gets ghc-9.2.1 builds in ci

  • update stack-exact.yaml default resolver to ghc-9.2.1 and update packages/package versions
  • the 9.2.1 builds do not execute the mini-hlint golden tests
    • this is a stack issue; the next upgrade will unblock re-enabling them
  • ghc-lib-gen for 9.2.1
    • -fwarn-incomplete-uni-patterns seems to have become the default; disable it
    • aeson got a super major version upgrade: notes on migration here
  • azure configuration updates:
    • add 9.2.1 builds and remove some older ones
    • move 9.0.1 builds off stack-exact.yaml and onto stack-901.yaml (works around a happy problem encountered when used with stack.yaml)
    • swap out some 8.10.4 builds for 8.10.7 ones

Copy link
Contributor

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

# | linux | ghc-master | ghc-9.2.1 |
# | macOS | ghc-master | ghc-9.2.1 |
# +---------+-----------------+------------+
linux-ghc-master-9.2.1:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m a bit worried that we just keep extending the number of CI jobs. I think we should start thinking about which ones we can drop reasonably. Maybe 8.8 can go (excluding the daml fork), maybe we can limit cross-platform tests to only the most recent one.

Nothing for this PR but I think we have to address this soonish.

, let genStringAction = stack stackYaml resolver $ "--no-terminal exec -- mini-hlint " ++ hsFile
]
goldenTests stackYaml@(StackYaml yaml) stackResolver@(Resolver resolver) (GhcFlavor ghcFlavor) hsFiles =
-- Note: You'll get very confused if you load expect files into your
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not change the tests to write out a trailing newline?

@cocreature
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@cocreature cocreature merged commit 75bb3ef into digital-asset:master Nov 15, 2021
@shayne-fletcher shayne-fletcher deleted the ghc-9.2.1 branch November 15, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants