-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
less stack more cabal #540
less stack more cabal #540
Conversation
81baf41
to
057ef87
Compare
Hey Shayne, thank you for the patience, we had some big deadlines last week! |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Thanks Shayne! I have two questions:
|
no, no deep reason. i'll explain further below.
sure. it's not 8.4.3-8.4.3 being tested (is there a label wrong somewhere?) but ghc-flavor
actually, you'll see that it is tested on macos in the azure config. what you are referring to i think is that there isn't a github action for testing it. the reason for that is github actions appear to provide aarch64 machines for macos and ghcup fails to install these older compilers (tried 8.4.3 and 8.8.1) there. on the other hand, azure appears to provide x86_64 arch macos machines. i'd say that's why that test remains in azure but is absent from the github actions. update: #534 (comment) |
@paulbrauner-da ping? |
Sounds good to me, but I'll leave it to Paul - I've pinged him on DA's Slack |
@dylant-da thank-you. between this PR and #541 in the queue behind it i've put in 100+hours on this work. i sure would appreciate being unblocked. |
Hey Shayne, sorry for the delays, but we need to have a discussion with security internally to make sure changing GitHub actions, etc. is okay from their end. |
that's fine, how we resolve #534 is independent of this PR and the one that follows. nothing in these PRs stops testing using azure resources. blocking on this issue doesn't make any sense here. |
Thank you for your patience @shayne-fletcher, we've now enabled GitHub actions, and I've approved the PR. |
I have enabled Github Actions for this one repo |
thanks @paulbrauner-da but please understand approving it isn't sufficient. i do not have write permission. you need to land it. |
nice 🎉 ! that being so, i'll amend #541 (in the queue behind this) such that azure is replaced by github going forward. |
My bad, done. |
@paulbrauner-da @dylant-da it looks like i've found a solution to this. there are some x86_64 runners available (https://github.com/actions/runner-images?tab=readme-ov-file#available-images). i'll circle back with a diff when the issues with the repo config that are currently blocking landing PRs are resolved. |
this PR removes any and all uses of stack in this project. it is replaced completely by ghcup and cabal. there's a bit of cleanup work that will follow but the key objective of removing stack is done.