Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less stack more cabal #540

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

shayne-fletcher
Copy link
Contributor

this PR removes any and all uses of stack in this project. it is replaced completely by ghcup and cabal. there's a bit of cleanup work that will follow but the key objective of removing stack is done.

@shayne-fletcher shayne-fletcher requested a review from a team as a code owner July 15, 2024 01:30
@shayne-fletcher shayne-fletcher marked this pull request as draft July 15, 2024 01:39
@shayne-fletcher shayne-fletcher marked this pull request as ready for review July 15, 2024 02:29
@shayne-fletcher
Copy link
Contributor Author

@basvangijzel-DA
Copy link

Hey Shayne, thank you for the patience, we had some big deadlines last week!

@basvangijzel-DA
Copy link

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulbrauner-da
Copy link

Thanks Shayne! I have two questions:

  • Would you mind summarizing the changes you made to the azure config outside of the stack->cabal migration? In particular, cases like 8.8.1-8.8.1 seem to have disappeared but 8.8.1-8.4.3 have appeared.
  • Is there a reason why the github actions don't test exactly the same cases?
    • 8.8.1-8.4.3 doesn't seem to be tested, instead 8.4.3-8.4.3 is
    • 8.4.3 is not tested on macos.

@shayne-fletcher
Copy link
Contributor Author

shayne-fletcher commented Jul 15, 2024

@paulbrauner-da

Thanks Shayne! I have two questions:

  • Would you mind summarizing the changes you made to the azure config outside of the stack->cabal migration? In particular, cases like 8.8.1-8.8.1 seem to have disappeared but 8.8.1-8.4.3 have appeared.
  • Is there a reason why the github actions don't test exactly the same cases?

no, no deep reason. i'll explain further below.

  • 8.8.1-8.4.3 doesn't seem to be tested, instead 8.4.3-8.4.3 is

sure. it's not 8.4.3-8.4.3 being tested (is there a label wrong somewhere?) but ghc-flavor --da using 8.4.3 as a build compiler. what's important here is that we test --da (which is 8.8.1 GHC source customized by DA. the choices for such a test are build compilers <= 8.8.1. i happened to test with build compiler 8.4.3. if you think it important (i don't) we can go back to 8.8.1 for the build compiler for this test. let me know.

  • 8.4.3 is not tested on macos.

actually, you'll see that it is tested on macos in the azure config. what you are referring to i think is that there isn't a github action for testing it. the reason for that is github actions appear to provide aarch64 machines for macos and ghcup fails to install these older compilers (tried 8.4.3 and 8.8.1) there. on the other hand, azure appears to provide x86_64 arch macos machines. i'd say that's why that test remains in azure but is absent from the github actions.

update: #534 (comment)

@shayne-fletcher
Copy link
Contributor Author

@paulbrauner-da ping?

@dylant-da
Copy link

Sounds good to me, but I'll leave it to Paul - I've pinged him on DA's Slack

@shayne-fletcher
Copy link
Contributor Author

Sounds good to me, but I'll leave it to Paul - I've pinged him on DA's Slack

@dylant-da thank-you. between this PR and #541 in the queue behind it i've put in 100+hours on this work. i sure would appreciate being unblocked.

@basvangijzel-DA
Copy link

Hey Shayne, sorry for the delays, but we need to have a discussion with security internally to make sure changing GitHub actions, etc. is okay from their end.

@shayne-fletcher
Copy link
Contributor Author

shayne-fletcher commented Jul 17, 2024

Hey Shayne, sorry for the delays, but we need to have a discussion with security internally to make sure changing GitHub actions, etc. is okay from their end.

that's fine, how we resolve #534 is independent of this PR and the one that follows. nothing in these PRs stops testing using azure resources. blocking on this issue doesn't make any sense here.

@paulbrauner-da
Copy link

Thank you for your patience @shayne-fletcher, we've now enabled GitHub actions, and I've approved the PR.

@nycnewman
Copy link
Collaborator

I have enabled Github Actions for this one repo

@shayne-fletcher
Copy link
Contributor Author

Thank you for your patience @shayne-fletcher, we've now enabled GitHub actions, and I've approved the PR.

thanks @paulbrauner-da but please understand approving it isn't sufficient. i do not have write permission. you need to land it.

@shayne-fletcher
Copy link
Contributor Author

I have enabled Github Actions for this one repo

nice 🎉 ! that being so, i'll amend #541 (in the queue behind this) such that azure is replaced by github going forward.

@paulbrauner-da paulbrauner-da merged commit b901fad into digital-asset:master Jul 17, 2024
14 checks passed
@paulbrauner-da
Copy link

thanks @paulbrauner-da but please understand approving it isn't sufficient. i do not have write permission. you need to land it.

My bad, done.

@shayne-fletcher shayne-fletcher deleted the stack-must-go branch July 17, 2024 17:46
@shayne-fletcher
Copy link
Contributor Author

  • 8.4.3 is not tested on macos.

@paulbrauner-da @dylant-da it looks like i've found a solution to this. there are some x86_64 runners available (https://github.com/actions/runner-images?tab=readme-ov-file#available-images). i'll circle back with a diff when the issues with the repo config that are currently blocking landing PRs are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants