Optimizing the make valid geometry query #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdsmith-scottlogic
approved these changes
Oct 10, 2023
morgan-sl
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes two points as part of this PR:
The Make_valid query was updating the entire entity table when invalid geometries were encountered, Filtered this out now based on which dataset is being processed.
ST_IsValid() function is failing for complex geometries. Used ST_IsSimple() to detect such geometries and then update them to valid geometries
Reference ticket: https://trello.com/c/lU5ILKCu/749-bug-fix-postgresql-cpu-issues