Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised bucket input parameters #16

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Conversation

cpcundill
Copy link
Contributor

@cpcundill cpcundill commented Jul 16, 2024

Revised input parameters into AWS S3 Object ARN instead of separate bucket and key; a necessary change since referencing via ARNs is the only reliable way this task can be triggered via EventBridge on CloudTrail events.

…ucket and key; a necessary change since referencing via ARNs is the only reliable way the builder can be triggered via EventBridge on CloudTrail events.
Copy link
Contributor

@eveleighoj eveleighoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S3_KEY is the path within the bucket, you could have load local get this from the ARN and just go to the files CDN to get it if you didn't want separate variables. But it's not the end of the world

…3_KEY) from the S3_OBJECT_ARN, rather than having a separate parameter for local running
@cpcundill cpcundill merged commit 5b37861 into main Jul 16, 2024
4 checks passed
@cpcundill cpcundill deleted the feature/revised-input-parameters branch July 16, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants