Add Dataset Chart to Performance page #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DilwoarH
commented
Oct 22, 2024
| month_year; | ||
| ` | ||
|
|
||
| fetch(`https://datasette.planning.data.gov.uk/digital-land.json?sql=${encodeURIComponent(sql)}`) |
There was a problem hiding this comment.
@eveleighoj - this is throwing a CORs error, is there a way round this problem? Do I need to create a route to proxy the request?
DilwoarH
force-pushed
the
add-chart-to-performance-page
branch
from
5d1ec0e
to
9ab7831
Compare
eveleighoj
temporarily deployed
to
development
GitHub Actions
Inactive
eveleighoj
approved these changes
Oct 22, 2024
8 tasks
DilwoarH
changed the title
|
Blocked by release to prod digital-land/datasette-builder#18 |
Merging now as this has been released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Add Dataset Chart to Performance page
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Added/updated tests?
We encourage you to keep the code coverage percentage at 80% and above.
have not been included
[optional] Are there any post deployment tasks we need to perform?
[optional] Are there any dependencies on other PRs or Work?