Check for NativeBuffer in ed25519#messageToNativeBuffer #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this technically is not necessary, because node.js' Buffer inherits from Uint8Array this contract is broken by jest. See jestjs/jest#4422. Add a `message instanceof NativeBuffer` to the function to fix the issue, it does no harm and *technically* would be the more correct check, because for node.js passing a raw Uint8Array does not return a Buffer.
dlongley
approved these changes
Jul 23, 2019
|
Any update about this? 😃 |
|
I'll pull this in since we're doing a release of related code. Seems like maybe that check should just be for NativeBuffer. Would be nice to have some tests for this if anyone wants to figure that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this technically is not necessary, because node.js' Buffer
inherits from Uint8Array this contract is broken by jest.
See jestjs/jest#4422.
Add a
message instanceof NativeBufferto the function to fix the issue,it does no harm and technically would be the more correct check, because
for node.js passing a raw Uint8Array does not return a Buffer.
I can also adjust the function to wrap the
Uint8Arrayin aBuffer, ifNativeBuffer === Bufferto be super correct. Just let me know.