Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching an item's history in the UI triggers a full-page redraw #62

Closed
basilesimon opened this issue Aug 26, 2021 · 2 comments
Closed
Labels
about:ui bug Something isn't working

Comments

@basilesimon
Copy link
Member

I believe this is a relatively recent regression, but am unable to pin down where from.

The process of displaying an item's history is relatively convoluted and requires the clicking of a button.

This action triggers Ledger.addHistoryTo(entry), which updates the $ledgerData (which is a store).

I would have expected this update to not trigger a full-page redraw, but it does.

@basilesimon basilesimon added bug Something isn't working about:ui labels Aug 26, 2021
@basilesimon
Copy link
Member Author

I've located the regression: it's "WIP: Verify an archive" pull request.

This PR introduces a fade:in Svelte transition to the <LedgerEntries />.

I was under the impression that Stores would behave a little differently, but this Issue put me on the right track: it's not the async nature of my stores that is the issue here, and we do expect a whole-store comparison when it's updated.

The faded transition only makes it more obvious. It was added as a cosmetic change: when looking at the /verify route, we drag and drop pictures that are reverse-looked up in the database, and positive matches appear in the UI as the requests come back. A little fade made it look quite nice, and that was that.

I'll have a think about what to do here.

@basilesimon
Copy link
Member Author

@bayre – this is the issue I mentioned to you yesterday. Looks like I'm sorted!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
about:ui bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant