-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API: Add social media headers endpoint #2084
Comments
I think this really has a lot of potential. It is always better to render SEO tags on the initial render. Therefore, directly injecting them on the server makes lots of sense and is also how SEO is implemented traditionally. Currently, it feels like a mix between the responsibilities in the nginx and the frontend. Minimum requirementsAs a minimum requirement AdditionsWe could also inject JSON-LD for events or breadcrumbs in the backend, which we are currently implementing in the frontend. ProblemsI am not sure if all sites in the frontend are also present Additional contextFor more context check out IGAPP-100 Medium:• Facebook: Beitrag teilen, Sharing-Text als Beitragstext Ansicht:Anzeigebild (vorhandenes Bild aus der Web App (wenn kein Bild vorhanden ist, dann vom Promo Team ausgewähltes Bild benutzen), Titel, Anfang vom Text (Teaser) Sprache:Anzeige in der jeweilig genutzten Sprache Sharing-Text:„Gerade in der #IntegreatApp entdeckt. Was hältst du davon?“ |
I added a bug label because there is a bug in our current implementation outside this CMS. The current solution does not work for HTTP/2 connections. |
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Co-authored-by: Timo Brembeck <[email protected]>
Motivation
We currently have a quick and dirty solution for rendering social media headers (https://git.tuerantuer.org/Integreat/social-media-meta-tags/src/branch/master/meta.php). This should be replaced by a long term solution within the CMS.
Proposed Solution
We probably need to keep the part with the Nginx Server Side Includes. However, we should move the functionality of the PHP script directly into the CMS and also support events, locations, etc.
Alternatives
Implement the full URL pattern and API functionality in our hacky PHP script. :-(
Additional Context
Design Requirements
The text was updated successfully, but these errors were encountered: