Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side validation in event form #246

Closed
1 of 2 tasks
timobrembeck opened this issue Nov 25, 2019 · 1 comment · Fixed by #2814
Closed
1 of 2 tasks

Client side validation in event form #246

timobrembeck opened this issue Nov 25, 2019 · 1 comment · Fixed by #2814
Assignees
@theresantonie
Labels
effort: low Should be doable in <4h enhancement This improves an existing feature good first issue Good for newcomers prio: low Not urgent, can be resolved in the distant future.
Milestone
Backlog

Comments

@timobrembeck
Copy link
Member

timobrembeck commented Nov 25, 2019 •
edited by theresantonie
Loading

In the event form, certain fields depend on other fields and only specific combinations are possible. To enhance the user experience, we should add the "required"-attribute via Javascript whenever the associated checkbox is activated and vice versa.
Example:

  • start_time and end_time should be required when is_all_day is not checked.
    (fixed in 5426559)
  • recurrence_end_date should be required when has_recurrence_end_date is checked.
@timobrembeck timobrembeck added the prio: low Not urgent, can be resolved in the distant future. label Nov 25, 2019
@timobrembeck timobrembeck added this to the Additional Features milestone Nov 25, 2019
@timobrembeck timobrembeck added the feature New feature or request label Nov 25, 2019
timobrembeck added a commit that referenced this issue Jan 16, 2020
@ulliholtgrave @timobrembeck
Fix time/all_day representation in event form (fixes #253)
5426559 
- Fix clean method of event form to handle the time values correctly when changing the all_day checkbox
- Add JavaScript to manually change the validation of the time fields depending on the all_day checkbox (this is also part of #246)

Co-authored-by: Timo Ludwig <[email protected]>
timobrembeck added a commit that referenced this issue Jan 16, 2020
@ulliholtgrave @timobrembeck
Fix time/all_day representation in event form (fixes #253)
dde6997 
- Fix clean method of event form to handle the time values correctly when changing the all_day checkbox
- Add JavaScript to manually change the validation of the time fields depending on the all_day checkbox (this is also part of #246)

Co-authored-by: Timo Ludwig <[email protected]>
@svenseeberg svenseeberg mentioned this issue Mar 1, 2020
Open
9 tasks
@timobrembeck
Copy link
Member Author

@florianhofhammer I unassigned you since I wasn't sure whether you wanted to complete the issue - if you're still interested though, I can of course re-assign you 😉
Greetings from Berlin!

@timobrembeck timobrembeck added good first issue Good for newcomers effort: low Should be doable in <4h enhancement This improves an existing feature and removed feature New feature or request labels Oct 31, 2022
theresantonie added a commit that referenced this issue May 22, 2024
@theresantonie
fix issue #246
d3f5b6f 
Added support for client side validation of conditionally required field recurrence_end_date. 
Changed behaviour when input fields are un-hidden to display their previous values instead of empty fields.
Fixed missing removal of "required" attribute when selecting "all day" while a previous value is set for start time or end time input fields.
@theresantonie theresantonie mentioned this issue May 28, 2024
Merged
theresantonie added a commit that referenced this issue Jun 9, 2024
@theresantonie
Client side validation in event form (#2814)
2800b21 
* fix issue #246

Added support for client side validation of conditionally required field recurrence_end_date. 
Changed behaviour when input fields are un-hidden to display their previous values instead of empty fields.
Fixed missing removal of "required" attribute when selecting "all day" while a previous value is set for start time or end time input fields.

* fix linting issues

* Create 246.yml

Add release note for fix of issue 246
@MizukiTemma MizukiTemma mentioned this issue Jun 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theresantonie theresantonie

Labels
effort: low Should be doable in <4h enhancement This improves an existing feature good first issue Good for newcomers prio: low Not urgent, can be resolved in the distant future.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Client side validation in event form digitalfabrik/integreat-cms
3 participants
@timobrembeck @florianhofhammer @theresantonie