Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIX-threshold for translation should use the uprounded value #2756

Closed
dkehne opened this issue Apr 23, 2024 · 3 comments · Fixed by #2760
Closed

HIX-threshold for translation should use the uprounded value #2756

dkehne opened this issue Apr 23, 2024 · 3 comments · Fixed by #2760
Assignees
Labels
enhancement This improves an existing feature
Milestone

Comments

@dkehne
Copy link

dkehne commented Apr 23, 2024

Page: Residents' Registration Office (https://admin.integreat-app.de/dahme-spreewald/pages/de/32725/edit/). Hix value to see 15. color yellow.
Page: National Visa (D-Visa) (https://admin.integreat-app.de/dahme-spreewald/pages/de/33077/edit/). Hix value to see 15. color green.

Screenshot (1489)

If you move the mouse over it:
Where it is yellow, the value is: 14.995. Where it is green, the value is: 15.002.

If the HIX-Value is shown as 15 because it is rounded up from 14.995 it should be marked green and translations should be possible. So maybe we can adjust the logic here that the decision on the HIX-threshold is also done based on the rounded-up-value.

That would be great.

@dkehne dkehne added the enhancement This improves an existing feature label Apr 23, 2024
@MizukiTemma MizukiTemma self-assigned this Apr 23, 2024
@JoeyStk JoeyStk added this to the 24Q2 milestone Apr 25, 2024
@dkehne
Copy link
Author

dkehne commented Jun 11, 2024

@PeterNerlich @MizukiTemma thanks for the implemenation but i guess the function is now doing sth. completly different now.
It is now downgrading every hix-value. and also if i have a hix-value of 13.94 it is shown as 13.

So sth. is not working here, not sure if it comes from this update here or another.

@dkehne
Copy link
Author

dkehne commented Jun 11, 2024

Two things that have changed but were not proposed to change:

  • HIX-value is shown as "14" if it is "14.99".
  • Detailled mouseover was removed (so it is not possible to see the exact hix value anymore)

See for example: https://admin.integreat-app.de/testumgebung/pages/de/37330/edit/

The only thing we wanted to be changed here is that if the "rounding up"-logic shows e.g. 14 (which is enough to translate) then it should be possible to translate.

@MizukiTemma
Copy link
Member

@dkehne sorry for the unwanted changes 🥺

In this example

  • HIX value in the hix bar must be 14,99
  • Mouseover should show 14,988696629148205

Am I understanding correctly?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This improves an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants