Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HIX value display #2853

Closed
MizukiTemma opened this issue Jun 17, 2024 · 3 comments · Fixed by #2867
Closed

Fix HIX value display #2853

MizukiTemma opened this issue Jun 17, 2024 · 3 comments · Fixed by #2867
Assignees
Labels
bug Something isn't working prio: high Needs to be resolved ASAP.
Milestone

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Jun 17, 2024

Describe the Bug

After #2760 some unwanted changes have been introduced together: HIX value is shown as 9 instead of 9.73 and mouseover does not show the detailed HIX value anymore

Steps to Reproduce

  1. Activate HIX in Region Augsburg (in the local emvironment), set the user language to German
  2. Populate pages with HIX value by ./tools/integreat-cms-cli hix_bulk augsburg
  3. Go to the page "Gesundheitsamt" (for example), whose raw HIX score is 9,72960372960373.
  4. See "9" in the HIX bar and mouseover doesn't show anything

Expected Behavior

It shows "9.73" and mourseover reveals the exact HIX score "9,72960372960373"

Actual Behavior

It shows 9 and mouseover doesn't do anything

Additional Information

The problem 9 vs 9.73 can only be observed if German is selected in the user setting. This is due to the different style between German (9,73, with comma) and English (9.73 with dot) and parseFloat().

For more information and context, see #2756

Traceback
@MizukiTemma MizukiTemma added bug Something isn't working blocked Blocked by external dependency labels Jun 17, 2024
@MizukiTemma
Copy link
Member Author

MizukiTemma commented Jun 17, 2024

@dkehne Please confirm whether this is describing the wished status correctly or leave comments 🙏

@MizukiTemma MizukiTemma added this to the 24Q3 milestone Jun 17, 2024
@dkehne
Copy link

dkehne commented Jun 17, 2024

The mouseover is not necessary as long

  1. you show HIX-value with 2 comma digits e.g. 9.73 and NOT as 9
  2. The rounding up works well. So 9.735 is shown AND handled as 9.74. So if we would decrease the MT-threshold to 9.74, a value with 9.735 should work to translate

@MizukiTemma
Copy link
Member Author

@dkehne Thank you for quick reply 👍

@MizukiTemma MizukiTemma removed the blocked Blocked by external dependency label Jun 17, 2024
@MizukiTemma MizukiTemma self-assigned this Jun 18, 2024
@MizukiTemma MizukiTemma changed the title Fix HIX value display and revive mouseover function Fix HIX value display Jun 19, 2024
@MizukiTemma MizukiTemma added the prio: high Needs to be resolved ASAP. label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio: high Needs to be resolved ASAP.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants